This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix #3068 #4317
Closed
Fix #3068 #4317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if `openInForeground` is not a boolean (ex: it's null / undefined) Auditors: @rickycodes
4 tasks
|
I've updated the PR to match the requested feature exactly. I changed the code because we need to respect the application's behavior (instead of hijacking it with the user's settings). Basically, this will now default the Unfortunately, after trying this out, I don't think this is behavior that we want. I'll leave a comment in the original issue |
|
Closing this PR for the moment. Comment was left in #3068 and issue was closed as won't fix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #3068
I now realize this clashes with pull #3729, but I think this fix is perhaps slightly more elegant?
Figured I'd still throw my hat into the ring and see what your thoughts are :)
Please let me know if anything else is required.
example: