Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes #3068 Implements 'Switch to new tabs immediately' setting #3729

Closed
wants to merge 1 commit into from

Conversation

Autokrator
Copy link

@Autokrator Autokrator commented Sep 5, 2016

  • Used Github auto-closing keywords in the commit message.
  • Ran git rebase -i to squash commits if needed.
  1. Added functionality for the 'Switch to new tab immediately' setting
  2. Applied setting to work for redirects from about:bookmarks page
  3. Added condition to ignore pages starting with 'about:' except 'about:newtab'

@bbondy Sorry, but after rebasing my branch to master, I managed to pull every single commit that I did not have with comments and remarks. So my PR got the entire comment history for the past 20 days! I didn't really know how to fix it so I just made a clean PR for you. For future reference, how do I fast forward my branch to incorporate new changes while maintaining only my changes in the PR? Was I suppose to rebase twice to squash the new commits? Again, I apologize, I don't really have much experience with rebasing. I have also included my firefox research comment from the other PR below.

Firefox implementation
I looked how firefox handles this setting. Here are some of the things I noticed:

  • Switch immediately to new tab
  • "about" pages are prioritized and ignore this setting
  • bookmarks and history links open in the currently active tab
  • Ctrl/Cmd + click obeys preference value
  • using Ctrl/Cmd + Shift + click overrides the preference and opens tab as active frame
  • Switch immediately to new tab
  • Ctrl/Cmd + click obeys preference value
  • using Ctrl/Cmd + Shift + click overrides the preference and opens tab as background frame

So the most interesting behaviour is the Ctrl/Cmd + Shift + click override which basically does the opposite of the current value specified in the preferences. If I remove my check for "about:newtab" we will basically have the same behaviour as firefox.

Regarding the calls of newFrame not being updated, I saw these were previously defaulting to true, I'm not sure which calls lead to this, it's been there before this update. Let me know in more detail what you would like regarding this though, I can look into it.

@rickycodes rickycodes mentioned this pull request Sep 27, 2016
@bsclifton
Copy link
Member

bsclifton commented Nov 26, 2016

Closing this PR in favor of #4317 (which I'm doing some touch-ups with). Sorry that none of us could get to this sooner ☹️

@bsclifton bsclifton closed this Nov 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants