This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fixes #3068 Implements 'Switch to new tabs immediately' setting #3729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -i
to squash commits if needed.@bbondy Sorry, but after rebasing my branch to master, I managed to pull every single commit that I did not have with comments and remarks. So my PR got the entire comment history for the past 20 days! I didn't really know how to fix it so I just made a clean PR for you. For future reference, how do I fast forward my branch to incorporate new changes while maintaining only my changes in the PR? Was I suppose to rebase twice to squash the new commits? Again, I apologize, I don't really have much experience with rebasing. I have also included my firefox research comment from the other PR below.
Firefox implementation
I looked how firefox handles this setting. Here are some of the things I noticed:
So the most interesting behaviour is the Ctrl/Cmd + Shift + click override which basically does the opposite of the current value specified in the preferences. If I remove my check for "about:newtab" we will basically have the same behaviour as firefox.
Regarding the calls of
newFrame
not being updated, I saw these were previously defaulting to true, I'm not sure which calls lead to this, it's been there before this update. Let me know in more detail what you would like regarding this though, I can look into it.