This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
New tab button too high #3208
Labels
design
A design change, especially one which needs input from the design team.
polish
Nice to have — usually related to front-end/visual tasks.
QA/checked-Linux
QA/checked-macOS
QA/checked-Win32
QA/checked-Win64
Milestone
Comments
3 tasks
|
The perfect solution here should be using a FontAwesome icon like others but there is no proper one, which has been proposed here FortAwesome/Font-Awesome#2161 |
|
This is on the polish list. We will fix for 1.0. |
bradleyrichter
added
design
|
Thank you Bradley. I had no idea there was going to be a 1.0 so soon. Do you know when? I don't follow Brave browser very much, as it's not my primary browser, but I'm interested in it because it's the most lightweight browser I've tried so far. |
|
@D0J0P, the Brave Development Timeline says 1.0 will ship 26 August 2016. |
|
Thanks, @roqstr, so the 1.0.0 milestone says it’s due on the 9 September. It’d be very handy if the current version info was made available on the homepage with a link to the upcoming milestones. |
bbondy
added a commit
that referenced
this issue
Aug 17, 2016
Adjust new tab button position fixes #3208
This was referenced Aug 21, 2016
This was referenced Aug 23, 2016
This was referenced Aug 25, 2016
This was referenced Aug 27, 2016
bbondy
added a commit
that referenced
this issue
Aug 31, 2016
Auditors: @alexwykoff Test Plan: n/a General feedback for future release notes: Major new features at the top: Autofill is a major feature highlight but wasn’t listed, so should be at the top. A sub-fix of it was listed under fixes. Sub-fixes for a new feature: about:history is a new feature so sub-fixes related to that aren’t needed in release notes. Ditto ledger stuff. Exclude Tests: Anything that mentions fixing automated tests or tests shouldn’t be included. In general anything dev relatd doesn't need to be included. Some reformatting of titles needed so that a casual reader can understand it, remove sub-references to other issues inside titles. Duplicate bugs: “Fixed new tab button too high” and “Fixed new tab button position fixes #3208” are too similar so just mention one of them Simplify some titles: “Fixed Make targets.host UNIQUE, which auto-creates index” -> “Optimize HTTPS Everywhere” Remove text like “Like other browsers do” from titles Consistent naming of main features “non script” “noScript” -> “NoScript” Always end lines in a period. Thanks!
bbondy
added a commit
that referenced
this issue
Aug 31, 2016
Auditors: @alexwykoff Test Plan: n/a General feedback for future release notes: Major new features at the top: Autofill is a major feature highlight but wasn’t listed, so should be at the top. A sub-fix of it was listed under fixes. Sub-fixes for a new feature: about:history is a new feature so sub-fixes related to that aren’t needed in release notes. Ditto ledger stuff. Exclude Tests: Anything that mentions fixing automated tests or tests shouldn’t be included. In general anything dev relatd doesn't need to be included. Some reformatting of titles needed so that a casual reader can understand it, remove sub-references to other issues inside titles. Duplicate bugs: “Fixed new tab button too high” and “Fixed new tab button position fixes #3208” are too similar so just mention one of them Simplify some titles: “Fixed Make targets.host UNIQUE, which auto-creates index” -> “Optimize HTTPS Everywhere” Remove text like “Like other browsers do” from titles Consistent naming of main features “non script” “noScript” -> “NoScript” Always end lines in a period. Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I find that the new tab button on the tab bar is just a bit too high. It looks off-center. It would look better if it were centered.
The text was updated successfully, but these errors were encountered: