Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Adjust new tab button position fixes #3208 #3213

Merged
merged 4 commits into from
Aug 17, 2016
Merged

Adjust new tab button position fixes #3208 #3213

merged 4 commits into from
Aug 17, 2016

Conversation

Sh1d0w
Copy link

@Sh1d0w Sh1d0w commented Aug 16, 2016

Before:

After:

cc @bbondy @bridiver @diracdeltas

@bbondy
Copy link
Member

bbondy commented Aug 17, 2016

This currently breaks the alignment on macOS (probably windows too)

New code in this PR:
screenshot 2016-08-17 12 34 44

Old code:
screenshot 2016-08-17 12 35 03

I guess this is a font issue of some sort. Can you think of a way to solve it across both OS?

@Sh1d0w
Copy link
Author

Sh1d0w commented Aug 17, 2016

@bbondy Yes you are right, it seems like a font issue. It can be easilly solved by putting an icon instead of text there.

@bradleyrichter Can you provide some icon that you think should fit, or should I just make one looking exactly like the current one?

@bradleyrichter
Copy link
Contributor

@Sh1d0w

This should work:
ic_add_24px.svg.zip

@bradleyrichter
Copy link
Contributor

ic_add_48pt_3x

@Sh1d0w
Copy link
Author

Sh1d0w commented Aug 17, 2016

@bradleyrichter Thanks. Implemented and looks good.

@bbondy Can you please test it on macOS? Should be ok now I think.

@bbondy
Copy link
Member

bbondy commented Aug 17, 2016

Works but this changes the look as well. @bradleyrichter did you want the new look or old?

Old:
screenshot 2016-08-17 13 47 11

New:
screenshot 2016-08-17 13 47 31

@bradleyrichter
Copy link
Contributor

We can scale it up a bit and set the opacity down to 0.7.

@Sh1d0w
Copy link
Author

Sh1d0w commented Aug 17, 2016

@bradleyrichter Added opacity: 0.7 but couldn't find much difference

Let me know if this is ok for you or should I change it to lower value. I think 0.5 is looking more like the old version.

@Sh1d0w
Copy link
Author

Sh1d0w commented Aug 17, 2016

@bradleyrichter This is the look with 0.5 opacity

Edit: also rescaled the icon

@bbondy
Copy link
Member

bbondy commented Aug 17, 2016

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants