Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

ledger notification should have the style of the update bar #3257

Closed
diracdeltas opened this issue Aug 19, 2016 · 9 comments
Closed

ledger notification should have the style of the update bar #3257

diracdeltas opened this issue Aug 19, 2016 · 9 comments
Assignees
Labels
design A design change, especially one which needs input from the design team. feature/rewards
Milestone

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Aug 19, 2016

per #2407

Alert:
Hello! Your Brave Payments account is waiting for a fresh deposit.

Buttons:
[Later] [ Add funds... ]

Trigger:
1 day, and 5 days after a failed payment


Alert:
Hello! Are you ready to support the sites you use most?

Buttons:
[Not yet ] [ Sure, I'll try... ]

Trigger:
10 days after first run of Brave, if user has not yet enabled BP.


Alert:
Hello! Thanks for supporting your favorite websites! Your contribution of $15.00 was processed!

Buttons:
[Ok]

Trigger:
Immediately, upon ledger confirmation of contribution processing.

visual spec:

image

@diracdeltas diracdeltas added this to the Brave Ledger Integration milestone Aug 19, 2016
@diracdeltas diracdeltas added feature/rewards design A design change, especially one which needs input from the design team. labels Aug 23, 2016
@mrose17 mrose17 removed this from the Brave Ledger Integration milestone Aug 27, 2016
@mrose17 mrose17 added this to the 1.0.0 milestone Sep 7, 2016
@bradleyrichter bradleyrichter modified the milestones: 0.12.1dev, 1.0.0 Sep 9, 2016
@ayumi ayumi self-assigned this Sep 9, 2016
@diracdeltas
Copy link
Member Author

@ayumi there is a notification bar option i added, updateStyle, which is supposed to indicate that the NotificationBar should be styled like an UpdateBar. currently this option does nothing

@ayumi
Copy link
Contributor

ayumi commented Sep 11, 2016

I added custom notification styling in #3856.
To finish this 🎁 we need to add the 3 ledger notifications mentioned above.

@mrose17
Copy link
Member

mrose17 commented Sep 12, 2016

@ayumi - who needs to do the additions? is this a design thing, a coding thing, a policy thing? thanks!

@ayumi
Copy link
Contributor

ayumi commented Sep 12, 2016

@mrose17 Just a coding thing now – adding the triggers and alerts.

@mrose17
Copy link
Member

mrose17 commented Sep 12, 2016

excellent!

@bbondy
Copy link
Member

bbondy commented Sep 21, 2016

Anything else need to block 0.12.2 for this?

@ayumi
Copy link
Contributor

ayumi commented Sep 21, 2016

I'm stuck on how to test the "thanks for your contribution" notification – I'm unable to trigger a ledger payment on demand. @mrose17 is there a way to try that?

Here it is implemented pending verification: master...feature/ledger-notifications-more

@mrose17
Copy link
Member

mrose17 commented Sep 21, 2016

sadly, there isn't a way to force the ledger to trigger a contribution on demand, other than to edit ledger-state*.json and watch it go. what is the PR for this? i can take a look in about 30m. thanks!

@ayumi
Copy link
Contributor

ayumi commented Sep 21, 2016

@mrose17 PR #4140

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/rewards
Projects
None yet
Development

No branches or pull requests

5 participants