Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add ledger payment success notification #4140

Merged
merged 2 commits into from
Sep 21, 2016
Merged

Add ledger payment success notification #4140

merged 2 commits into from
Sep 21, 2016

Conversation

ayumi
Copy link
Contributor

@ayumi ayumi commented Sep 21, 2016 •
edited
Loading

Adds notification on payment completion

Partially implement #3257

Auditors: @mrose17

Test Plan:

  1. Trigger a payment
  2. Observe payment complete notification

@ayumi ayumi mentioned this pull request Sep 21, 2016
Closed
@mrose17
when caching the transaction array for the purpose of doing isEqual...
7c85ae6 
…be sure to do a shallow copy of the transaction array
@ayumi
Copy link
Contributor Author

ayumi commented Sep 21, 2016

Reviewed with @mrose17 also thanks for the fix :)

@ayumi ayumi merged commit d4d561b into master Sep 21, 2016
@ayumi ayumi deleted the feature/ledger-notifications-more branch September 21, 2016 22:09
@luixxiul luixxiul added this to the 0.12.2dev milestone Sep 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
feature/rewards QA/test-plan-specified
Projects
None yet
Milestone
0.12.2dev
Development

Successfully merging this pull request may close these issues.
3 participants
@ayumi @luixxiul @mrose17