This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add notification to suggest users use Brave Payments #4141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auditors: @bsclifton Test Plan: Upgrading existing userData 1. Be on `master` and close Brave 2. Open session-store-1 with less (e.g. ~/Library/Application\ Support/brave-development/session-store-1) 3. See firstRunTimestamp is not there 4. Check out this branch 5. Open Brave, then close it 6. View again session-store-1 and see firstRunTimestamp is there 8. Restart Brave again, then close it 9. See firstRunTimestamp is see firstRunTimestamp is unchanged New profile 1. Delete userData dir (e.g. ~/Library/Application\ Support/brave-development) 2. Open Brave 3. Close Brave 4. View session-store-1 and see firstRunTimestamp
ayumi
force-pushed
the
feature/first-run-timestamp
branch
from
04ca066
to
ab440b2
Compare
diracdeltas
reviewed
Sep 22, 2016
| @@ -383,6 +391,9 @@ eventStore.addChangeListener(() => { | |||
| var initialize = (onoff) => { | |||
| enable(onoff) | |||
|
|
|||
| // Check if relevant browser notifications should be shown every 15 minutes | |||
| setInterval(showNotifications, 15 * msecs.minute) | |||
There was a problem hiding this comment.
clearInterval never gets called on this, so i think a new timer is added every time the user clicks the on/off switch. this may lead to notifications being shown more often than intended or something
There was a problem hiding this comment.
maybe add a global var to keep track of whether setInterval has already been called and do nothing here if it has
There was a problem hiding this comment.
thanks good call– it was originally there but i removed it (oops).
i added it back
|
otherwise 👍 |
ayumi
force-pushed
the
feature/first-run-timestamp
branch
from
ab440b2
to
47d7aaa
Compare
Auditors: @bsclifton @diracdeltas Test Plan: 1. Edit `ledger.js` to reduce showNotifications delay interval to 3 * msecs.second 2. Run Brave with an existing profile 3. Confirm there's no notification 4. Close Brave 5. Update userData session-store-1 firstRunTimestamp to be way in the past e.g. from '14..' to '13..' (~/Library/Application\ Support/session-store-1) 6. Open Brave 7. Confirm notification
ayumi
force-pushed
the
feature/first-run-timestamp
branch
from
47d7aaa
to
35971f5
Compare
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Fix #3257 (Finishes the remaining task)
Auditors: @bsclifton @diracdeltas
Test Plan:
ledger.jsto reduce showNotifications delay interval to 3 * msecs.second