-
Notifications
You must be signed in to change notification settings - Fork 973
Open html file with drag and drop #3819
Comments
Resolves brave#3819 Auditors: @Sh1d0w @bradleyrichter Test Plan: - Open folder with a local file - Drag and drop one to the header section - File is opened
Resolves brave#3819 Auditors: @Sh1d0w @bradleyrichter Test Plan: - Open folder with a local file - Drag and drop one to the header section - File is opened
Fixed with #6404 |
Resolves #3819 Auditors: @Sh1d0w @bradleyrichter Test Plan: - Open folder with a local file - Drag and drop one to the header section - File is opened
Resolves #3819 Auditors: @Sh1d0w @bradleyrichter Test Plan: - Open folder with a local file - Drag and drop one to the header section - File is opened
Resolves #3819 Auditors: @Sh1d0w @bradleyrichter Test Plan: - Open folder with a local file - Drag and drop one to the header section - File is opened
Resolves #3819 Auditors: @Sh1d0w @bradleyrichter Test Plan: - Open folder with a local file - Drag and drop one to the header section - File is opened
I see where the problem is. If you dnd on a tab section it will be loaded correctly, but if you dnd it into URL bar, path will be searched. This of course happens only when you add link that doesn have space in path for example. Will fix it. |
Fixes brave#3819 Auditor: @luixxiul @bsclifton Test Plan: - try dnd file with a special char (space) into URL bar - file should be opened correctly
Fixed drag and drop for local files into URL bar
PR addressing this issue was merged after I confirmed the fix; It will be in the next RC 👍 |
Reopened just in case; please close this if #7057 has fixed it too. |
confirmed this is an issue in rc3 on win ia-32 cc: @bsclifton |
@alexwykoff @luixxiul this fix is not in rc3 yet, please try it in the next RC |
@NejcZdovc I thought you have fixed the drag and drop on the URL bar. I just wanted to make sure you have fixed the drag and drop on the tabs bar as well, which the new gif demonstrates on #3819 (comment) |
Will try all scenarious and see if I can reproduce this with the latest code. I wrote about RC's, because @alexwykoff said that he can reproduce it in rc 3, which does not have the latest code. Can you reproduce this latest bug on mac as well? |
@luixxiul #7057 fixes the issue for sure; I didn't try the tabs bar. Like @NejcZdovc is saying, this was fixed with the PR (#7057) so it's not in a release candidate yet @NejcZdovc if it works as expected for you in master, please close out the issue 😄 |
I think this works as it was spec'ed originally so I'm going to close this. For follow up work though I posted this one as a spin off: |
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
In chrome and FF if you drag and drop an HTML file from a folder to the Browser header section (where the tabs are located) they correctly open the local file in a new tab so you can preview it.
In Brave this is currently not possible.
Expected behavior:
Brave should open local html files for preview via drag and drop.
Platform (Win7, 8, 10? macOS? Linux distro?):
All
Brave Version:
0.12.0
Steps to reproduce:
Screenshot if needed:
Any related issues:
Test Plan:
The text was updated successfully, but these errors were encountered: