Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Open html file with drag and drop #3819

Closed
Sh1d0w opened this issue Sep 8, 2016 · 12 comments
Closed

Open html file with drag and drop #3819

Sh1d0w opened this issue Sep 8, 2016 · 12 comments

Comments

@Sh1d0w
Copy link

Sh1d0w commented Sep 8, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
In chrome and FF if you drag and drop an HTML file from a folder to the Browser header section (where the tabs are located) they correctly open the local file in a new tab so you can preview it.
In Brave this is currently not possible.

Expected behavior:
Brave should open local html files for preview via drag and drop.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version:
    0.12.0

  • Steps to reproduce:

    1. Open a folder containing html files
    2. Drag one of the to the Brave's header section
    3. Nothing happens
  • Screenshot if needed:

  • Any related issues:

Test Plan:

  1. Open folder with a local file
  2. Drag and drop one to the header section
  3. File is opened
@bradleyrichter bradleyrichter added this to the 1.0.0 milestone Nov 3, 2016
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Dec 23, 2016
Resolves brave#3819

Auditors: @Sh1d0w @bradleyrichter

Test Plan:
- Open folder with a local file
- Drag and drop one to the header section
- File is opened
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Dec 23, 2016
Resolves brave#3819

Auditors: @Sh1d0w @bradleyrichter

Test Plan:
- Open folder with a local file
- Drag and drop one to the header section
- File is opened
@bsclifton bsclifton modified the milestones: 0.13.1, 1.0.0 Jan 2, 2017
@NejcZdovc NejcZdovc self-assigned this Jan 9, 2017
@bsclifton
Copy link
Member

Fixed with #6404

bsclifton pushed a commit that referenced this issue Jan 24, 2017
Resolves #3819

Auditors: @Sh1d0w @bradleyrichter

Test Plan:
- Open folder with a local file
- Drag and drop one to the header section
- File is opened
bsclifton pushed a commit that referenced this issue Jan 25, 2017
Resolves #3819

Auditors: @Sh1d0w @bradleyrichter

Test Plan:
- Open folder with a local file
- Drag and drop one to the header section
- File is opened
bsclifton pushed a commit that referenced this issue Jan 25, 2017
Resolves #3819

Auditors: @Sh1d0w @bradleyrichter

Test Plan:
- Open folder with a local file
- Drag and drop one to the header section
- File is opened
bsclifton pushed a commit that referenced this issue Jan 26, 2017
Resolves #3819

Auditors: @Sh1d0w @bradleyrichter

Test Plan:
- Open folder with a local file
- Drag and drop one to the header section
- File is opened
@luixxiul
Copy link
Contributor

luixxiul commented Feb 4, 2017

The file path is instead searched:

searched

@luixxiul luixxiul reopened this Feb 4, 2017
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 4, 2017

I see where the problem is. If you dnd on a tab section it will be loaded correctly, but if you dnd it into URL bar, path will be searched. This of course happens only when you add link that doesn have space in path for example. Will fix it.

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 4, 2017
Fixes brave#3819

Auditor: @luixxiul @bsclifton

Test Plan:
- try dnd file with a special char (space) into URL bar
- file should be opened correctly
bsclifton added a commit that referenced this issue Feb 4, 2017
Fixed drag and drop for local files into URL bar
@bsclifton
Copy link
Member

bsclifton commented Feb 4, 2017

PR addressing this issue was merged after I confirmed the fix; It will be in the next RC 👍

@luixxiul
Copy link
Contributor

luixxiul commented Feb 4, 2017

if you dnd it into URL bar

Sorry for the bad gif demonstration, but the error can happen as well dragging the file onto the tab:

dnd

@luixxiul luixxiul reopened this Feb 4, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Feb 4, 2017

Reopened just in case; please close this if #7057 has fixed it too.

@alexwykoff
Copy link
Contributor

confirmed this is an issue in rc3 on win ia-32

cc: @bsclifton

@NejcZdovc
Copy link
Contributor

@alexwykoff @luixxiul this fix is not in rc3 yet, please try it in the next RC

@luixxiul
Copy link
Contributor

luixxiul commented Feb 4, 2017

@NejcZdovc I thought you have fixed the drag and drop on the URL bar. I just wanted to make sure you have fixed the drag and drop on the tabs bar as well, which the new gif demonstrates on #3819 (comment)

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 4, 2017

Will try all scenarious and see if I can reproduce this with the latest code. I wrote about RC's, because @alexwykoff said that he can reproduce it in rc 3, which does not have the latest code. Can you reproduce this latest bug on mac as well?

@bsclifton
Copy link
Member

bsclifton commented Feb 4, 2017

@luixxiul #7057 fixes the issue for sure; I didn't try the tabs bar. Like @NejcZdovc is saying, this was fixed with the PR (#7057) so it's not in a release candidate yet

@NejcZdovc if it works as expected for you in master, please close out the issue 😄

@bbondy
Copy link
Member

bbondy commented Feb 5, 2017

I think this works as it was spec'ed originally so I'm going to close this.

For follow up work though I posted this one as a spin off:
#7079

@bbondy bbondy closed this as completed Feb 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants