This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fixed copy to clipboard(Flash plugin) blocked on Reverso.net #4020
Labels
Milestone
Comments
|
@srirambv i don't see a 'copy' element in either Chrome or Brave. |
|
nvm, i found it. there is an issue with flash detection when shields are down. |
diracdeltas
added a commit
that referenced
this issue
Mar 16, 2017
Separates plugin content setting from flashEnabled setting so that shields down allows tiny flash elements to be detected. Also improves hidden element detection for slow/delayed element loads. Fix #4020 Auditors: @srirambv @bbondy Test Plan: 1. go to reverso.net with flash enabled in about:preferences and shields down 2. enter something in the box and click translate 3. you should see a flash notification bar. click 'allow' 4. click on the copy-paste icon in the results box. the page should tell you that the text was copied.
4 tasks
|
Note: needs next preview to test this (it's on the master branch yet) |
jonathansampson
pushed a commit
that referenced
this issue
Mar 18, 2017
Separates plugin content setting from flashEnabled setting so that shields down allows tiny flash elements to be detected. Also improves hidden element detection for slow/delayed element loads. Fix #4020 Auditors: @srirambv @bbondy Test Plan: 1. go to reverso.net with flash enabled in about:preferences and shields down 2. enter something in the box and click translate 3. you should see a flash notification bar. click 'allow' 4. click on the copy-paste icon in the results box. the page should tell you that the text was copied.
This was referenced Mar 21, 2017
|
Not working on Windows x64 0.14.0 Preview 4 build. |
|
@srirambv as stated in the PR test plan, you have to turn shields down on reverso.net first |
|
Sorry my bad. Missed the shields down part.. Works as expected. |
alexwykoff
changed the title
This was referenced Mar 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test Plan:
Original issue description
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Copy to clipboard(Flash plugin) blocked on Reverso.net.
Expected behavior:
Should allow the plugin to run to enable clipboard functionality
Platform (Win7, 8, 10? macOS? Linux distro?):
Windows 10 x64
Brave Version:
0.12.1 RC1 (Clean Install)
Steps to reproduce:
Screenshot if needed:
Flash content on Chrome
Brave
Clipboard item blocked after page refresh
Any related issues:
cc: @diracdeltas
The text was updated successfully, but these errors were encountered: