Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added notification for Flash elements that are too small for the placeholder #7523

Closed
diracdeltas opened this issue Mar 7, 2017 · 3 comments
Closed

Added notification for Flash elements that are too small for the placeholder #7523

diracdeltas opened this issue Mar 7, 2017 · 3 comments
Assignees
@diracdeltas
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.14.0

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Mar 7, 2017 •
edited by luixxiul
Loading

Test plan

#7528 (comment)

maybe similar to the noscript icon, or just the regular notification bar
@diracdeltas diracdeltas added this to the 0.13.6 milestone Mar 7, 2017
@diracdeltas diracdeltas self-assigned this Mar 7, 2017
diracdeltas added a commit that referenced this issue Mar 8, 2017
@diracdeltas
Show Flash notification bar if page loads small/hidden Flash elements
f1236fb 
Fix #7523

Test Plan:
1. automated flash tests should pass
@diracdeltas diracdeltas mentioned this issue Mar 8, 2017
Merged
4 tasks
This was referenced Mar 14, 2017
Closed
Closed
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

I am still not able to see the small flash item mentioned in #4020.

@alexwykoff alexwykoff mentioned this issue Mar 16, 2017
Closed
@alexwykoff
Copy link
Contributor

alexwykoff commented Mar 16, 2017 •
edited
Loading

Currently on 77c562c and was unable to get Brave to recognize Flash had been installed on Linux Mint.

Saw this on the console, not sure if helpful:
[2014:2014:0315/234337.074039:ERROR:browser_plugin_guest.cc(443)] Attempting to require callback on nonexistent surface
Signature verified in registerUserFinal.

Related issue : #7505

@luixxiul luixxiul added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Mar 16, 2017
@diracdeltas
Copy link
Member Author

@srirambv reverso.net actually has two different Flash issues, one of which is solved by #7549. when shields are down, you can actually see the Flash element which is very small

i'll fix the smallness problem but you will still need to lower shields.

This was referenced Mar 17, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Mar 21, 2017
Closed
@alexwykoff alexwykoff changed the title show notification for Flash elements that are too small for the placeholder Added notification for Flash elements that are too small for the placeholder Mar 27, 2017
@alexwykoff alexwykoff mentioned this issue Mar 28, 2017
Closed
@cndouglas cndouglas removed the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Mar 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
5 participants
@diracdeltas @alexwykoff @luixxiul @srirambv @cndouglas