Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed Flash discovery for sites if shields are down #7549

Closed
diracdeltas opened this issue Mar 8, 2017 · 0 comments · Fixed by #7563
Closed

Fixed Flash discovery for sites if shields are down #7549

diracdeltas opened this issue Mar 8, 2017 · 0 comments · Fixed by #7563
Assignees
@diracdeltas
Labels
plugin/flash QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.14.0

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Mar 8, 2017 •
edited by luixxiul
Loading

Test plan

#7563 (comment)

#4789 (comment)
@diracdeltas diracdeltas added this to the 0.13.6 milestone Mar 8, 2017
@diracdeltas diracdeltas self-assigned this Mar 8, 2017
diracdeltas added a commit that referenced this issue Mar 8, 2017
@diracdeltas
allow sites to detect flash when shields are down
a883796 
fix #7549

Auditors: @bridiver

Test Plan:
0. enable flash in preferences
1. go to http://tv-trwam.pl/na-zywo
2. turn off shields. the flash placeholder should appear.
@diracdeltas diracdeltas mentioned this issue Mar 8, 2017
Merged
@alexwykoff alexwykoff mentioned this issue Mar 14, 2017
Closed
44 tasks
@diracdeltas diracdeltas mentioned this issue Mar 16, 2017
Closed
This was referenced Mar 17, 2017
Closed
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Mar 21, 2017
Closed
@diracdeltas diracdeltas mentioned this issue Mar 21, 2017
Closed
@alexwykoff alexwykoff changed the title if flash is enabled, 'shields down' should allow the site to see that flash is installed Fixed Flash discovery for sites if shields are down Mar 27, 2017
@alexwykoff alexwykoff mentioned this issue Mar 28, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
plugin/flash QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

allow sites to detect flash when shields are down brave/browser-laptop
4 participants
@diracdeltas @alexwykoff @luixxiul @srirambv