Flash UX improvement tracking issue

[alexwykoff]

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Flash support is taking up an inordinate amount of time to triage and fix on a onsey-twosey basis. We need a more comprehensive strategy to make Flash work for users because we are not fully deprecating it anytime soon. (see #testers channel 14/10/2016 & https://github.com/brave/browser-laptop/wiki/Flash-Support-Deprecation-Proposal)

Expected behavior:
TBD by @bradleyrichter but I would imagine something obvious and visible on the URL bar like most common flash blockers(#3972) or a banner. Also a direct and easy flow to install and enable Flash(#4754).

• Platform (Win7, 8, 10? macOS? Linux distro?):
  All
• Brave Version:
  > 0.21.5
• Any related issues:
  Feature Request : Add Flash enabler icon in address bar #3972
  Clarify enabling Flash on Brave #4754
  Certain Flash games on Facebook doesn't load  #4397
  Flash cover slide not shown on youku.com #4532
  Feature Request : Add Flash enabler icon in address bar #3972
  link to Flash install wiki in prefs #5618

[diracdeltas]

first/easiest step to this is just putting the flash troubleshooting guide from https://github.com/brave/browser-laptop/wiki/Flash-Support-Deprecation-Proposal into the UI soemwhere

[alexwykoff]

http://tv-trwam.pl/na-zywo is another site which really does not play well (at all), even with shields down.

[diracdeltas]

#4789 (comment) has been addressed and #7528 hopefully addresses the rest of this

[diracdeltas]

http://tv-trwam.pl/na-zywo uses jwplayer, which has html5 fallback, so it's unclear why they haven't enabled it.

it is an example of a site where there is currently no way for Brave to figure out that it's trying to run Flash; it doesn't load the Flash content because Brave doesn't advertise Flash support, its HTML5 fallback isn't working, and it isn't trying to get the user to go to adobe.com to install Flash.

when shields is down, we should probably just allow the site to see that Flash is installed.

[diracdeltas]

http://tv-trwam.pl/na-zywo is covered by an open PR and most of those issues are fixed so i'm moving this to a later milestone