Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Import Browser Data is shown under Help menu #4177

Closed
srirambv opened this issue Sep 22, 2016 · 0 comments · Fixed by #4182
Closed

Import Browser Data is shown under Help menu #4177

srirambv opened this issue Sep 22, 2016 · 0 comments · Fixed by #4182
Assignees
@darkdh
Labels
feature/importer QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.2dev

Comments

@srirambv
Copy link
Collaborator

srirambv commented Sep 22, 2016 •
edited
Loading

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Import Browser Data is shown under Help menu

Expected behavior:
Should be under Bookmarks menu

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64
  • Brave Version:
    0.12.2 Dev RC1
  • Steps to reproduce:
    1. Go to help under menu/hamburger menu
    2. Import Browser data is shown under help
    3. Showing it under Bookmark menu seems appropriate since it brings up the import bookmark modal
  • Screenshot if needed:
    image
  • Any related issues:

cc: @darkdh
@srirambv srirambv added this to the 0.12.2dev milestone Sep 22, 2016
@darkdh darkdh self-assigned this Sep 22, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Sep 22, 2016
@darkdh
Move importBrowserData option to obvious place
0b654e6 
Auditors: @bsclifton

fix brave#4177

Test Plan:
for menubar:
1. importBrowserData option is under "Brave" and "Bookmarks" on mac
2. importBrowserData option is under "Bookmarks" on linux and windows

for hamburger menu:
importBrowserData option is under "Bookmarks" on all platforms
@darkdh darkdh mentioned this issue Sep 22, 2016
Merged
4 tasks
This was referenced Sep 22, 2016
Closed
Closed
Closed
Closed
This was referenced Sep 24, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/importer QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.2dev
Development

Successfully merging a pull request may close this issue.

Move importBrowserData option to obvious place darkdh/browser-laptop
4 participants
@aekeus @alexwykoff @darkdh @srirambv