Skip to content

Commit

Permalink
Move importBrowserData option to obvious place
Browse files Browse the repository at this point in the history
Auditors: @bsclifton

fix brave#4177

Test Plan:
for menubar:
1. importBrowserData option is under "Brave" and "Bookmarks" on mac
2. importBrowserData option is under "Bookmarks" on linux and windows

for hamburger menu:
importBrowserData option is under "Bookmarks" on all platforms
  • Loading branch information
darkdh committed Sep 22, 2016
1 parent 2b76366 commit 0b654e6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions app/browser/menu.js
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,9 @@ const createBookmarksSubmenu = () => {
},
CommonMenu.separatorMenuItem,
CommonMenu.bookmarksManagerMenuItem(),
CommonMenu.bookmarksToolbarMenuItem()
CommonMenu.bookmarksToolbarMenuItem(),
CommonMenu.separatorMenuItem,
CommonMenu.importBrowserDataMenuItem()
]

const bookmarks = menuUtil.createBookmarkMenuItems(appStore.getState().get('sites'))
Expand Down Expand Up @@ -459,8 +461,6 @@ const createHelpSubmenu = () => {
submenu.push(CommonMenu.separatorMenuItem)
submenu.push(CommonMenu.checkForUpdateMenuItem())
submenu.push(CommonMenu.separatorMenuItem)
submenu.push(CommonMenu.importBrowserDataMenuItem())
submenu.push(CommonMenu.separatorMenuItem)
submenu.push(CommonMenu.aboutBraveMenuItem())
}

Expand Down
6 changes: 3 additions & 3 deletions js/contextMenus.js
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,9 @@ function hamburgerTemplateInit (location, e) {
label: locale.translation('bookmarks'),
submenu: [
CommonMenu.bookmarksManagerMenuItem(),
CommonMenu.bookmarksToolbarMenuItem()
CommonMenu.bookmarksToolbarMenuItem(),
CommonMenu.separatorMenuItem,
CommonMenu.importBrowserDataMenuItem()
]
}, {
label: locale.translation('bravery'),
Expand All @@ -643,8 +645,6 @@ function hamburgerTemplateInit (location, e) {
CommonMenu.separatorMenuItem,
CommonMenu.checkForUpdateMenuItem(),
CommonMenu.separatorMenuItem,
CommonMenu.importBrowserDataMenuItem(),
CommonMenu.separatorMenuItem,
CommonMenu.reportAnIssueMenuItem(),
CommonMenu.submitFeedbackMenuItem()
]
Expand Down

0 comments on commit 0b654e6

Please sign in to comment.