Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add funds bar comes up too often and should have turn off button #5418

Closed
bbondy opened this issue Nov 5, 2016 · 5 comments
Closed

Add funds bar comes up too often and should have turn off button #5418

bbondy opened this issue Nov 5, 2016 · 5 comments
Assignees
Milestone

Comments

@bbondy
Copy link
Member

bbondy commented Nov 5, 2016

When a user has 0 funds and Brave payments turned on, which will be a lot of people that just wanted to try the experience, shouldn't be prompted so often to add funds, and they should have an option to turn it off.

I think I had about 20 prompts for it yesterday and have had 2 already today and have only been on my computer for an hour.

I think just disabling brave payments would stop them, so maybe just adding a Turn Off button in the notification, and also make sure it doesn't come up more than once a day if they hit Later.

@bbondy bbondy added this to the 0.12.9dev milestone Nov 5, 2016
@bbondy
Copy link
Member Author

bbondy commented Nov 5, 2016

@ayumi pls take before starting on sync if you don't mind
@bradleyrichter cc'ed in case he wants to tweak the experience I suggested above.

@bbondy
Copy link
Member Author

bbondy commented Nov 5, 2016

I guess instead of turning off brave payments it should set the disable notifications in advanced maybe?

@bsclifton
Copy link
Member

@bbondy the easier to turn off the better, IMO 😄

@bradleyrichter
Copy link
Contributor

@bbondy There is obviously a bug if you are getting a notification more often than every 6 hours.

How about this:

1st alert after 24 hours past due.
Hitting "later" mutes for 3 days.
On the 3rd day, the later button changes to "Turn off notifications".

@bbondy
Copy link
Member Author

bbondy commented Nov 7, 2016

Just another button for turn off notifications please. And also don't show this if brave payments is disabled. I got the notification much more frequent than 6 hours. It really makes us feel like a "please purchase to stop this nag screen" app which isn't what we are. It's a big problem.

ayumi added a commit that referenced this issue Nov 7, 2016
Related: #5418

Auditors: @bsclifton

Test Plan:
1. Trigger the "Add funds" notification.
  - Update reconcileStamp to <24 hours from now (or a few days in the past)
  - Ensure not enough balance
2. Change startup notification delay in ledger.js L484 from 15m to 5s
3. Open Brave and observe notification
4. Close Brave and reopen. Notification should not reappear.
(Next Add funds notification timestamp is set in Application Support/brave-development/session-store-1 `notification-add-funds-timestamp`)
ayumi added a commit that referenced this issue Nov 7, 2016
Fix #5418

Auditors: @bsclifton

Test plan:
1. Trigger "Add funds" notification by having Payments enabled and editing session-store-1 reconcileDate to in the past
2. Observe notification with new "Turn off notification" button.
3. Click it
4. Open Preferences > Payments and click Advanced Settings... and observe notifications are disabled.
ayumi added a commit that referenced this issue Nov 8, 2016
Related: #5418

Auditors: @bsclifton

Test Plan:
1. Trigger the "Add funds" notification.
  - Update reconcileStamp to <24 hours from now (or a few days in the past)
  - Ensure not enough balance
2. Change startup notification delay in ledger.js L484 from 15m to 5s
3. Open Brave and observe notification
4. Close Brave and reopen. Notification should not reappear.
(Next Add funds notification timestamp is set in Application Support/brave-development/session-store-1 `notification-add-funds-timestamp`)
ayumi added a commit that referenced this issue Nov 8, 2016
Fix #5418

Auditors: @bsclifton

Test plan:
1. Trigger "Add funds" notification by having Payments enabled and editing session-store-1 reconcileDate to in the past
2. Observe notification with new "Turn off notification" button.
3. Click it
4. Open Preferences > Payments and click Advanced Settings... and observe notifications are disabled.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants