Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

about:brave page should have "copy to clipboard" button #5790

Closed
CliqueBait opened this issue Nov 22, 2016 · 12 comments
Closed

about:brave page should have "copy to clipboard" button #5790

CliqueBait opened this issue Nov 22, 2016 · 12 comments

Comments

@CliqueBait
Copy link

I like the recent change to version info. It looks cleaner than presenting a dialog. One downside though is that selecting and copying the info gives me this:

Brave 0.12.10
Muon 1.4.26
libchromiumcontent 53.0.2785.143
V8 5.3.332.47
Node.js 6.5.0
Update Channel dev
os.platform linux
os.release 4.8.0-27-generic
os.arch x64

It might be better to add a "copy to clipboard" button which provides something slightly easier to scan when pasted into issue tickets:

Brave: 0.12.10
Muon: 1.4.26
libchromiumcontent: 53.0.2785.143
V8: 5.3.332.47
Node.js: 6.5.0
Update Channel: dev
os.platform: linux
os.release: 4.8.0-27-generic
os.arch: x64

That's basically the text content format of the old dialog.

@srirambv
Copy link
Collaborator

#5693 should be able to cover this as well

@bsclifton
Copy link
Member

bsclifton commented Nov 22, 2016

This is a great idea- we're already integrated with a clipboard library, this should be a slam dunk 😄

@gyandeeps
Copy link
Contributor

I am trying to get my feet wet with brave code. Can I work on this issue and send my first PR?

@bsclifton
Copy link
Member

bsclifton commented Dec 8, 2016

@gyandeeps that would be awesome! I can help you along the way 😄

@bradleyrichter do you have a recommendation of how a "copy to clipboard" button would look? (and where it may go in relation to the current about:brave screen)?

edit:
I'm guessing we could just use FontAwesome (which we're already integrated with). Would be just adding some class names to the button (maybe the clipboard one here?)
screen shot 2016-12-08 at 11 35 28 am

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Dec 8, 2016 via email

@gyandeeps
Copy link
Contributor

Thanks @bsclifton and @bradleyrichter for giving all this info. The only thing left is where shoudl this icon be placed on the about page (top, bottom , etc)?

@bradleyrichter
Copy link
Contributor

@gyandeeps

How about this?

image

@gyandeeps
Copy link
Contributor

looks good to me. I will go with this design as of now unless somebody recommends something else.
Thanks @bradleyrichter

@CliqueBait
Copy link
Author

Thanks for volunteering time to this @gyandeeps . I'll have to get my feet wet soon too.

@bsclifton
Copy link
Member

That would be awesome, @CliqueBait 😄 Let us know if you have any questions

@bbondy bbondy closed this as completed in 942e95c Dec 13, 2016
bbondy added a commit that referenced this issue Dec 13, 2016
Update: Add copy to clipboard for about brave page (fixes #5790)
@bbondy bbondy modified the milestones: 0.12.15, 0.13.1 Dec 13, 2016
bbondy added a commit that referenced this issue Dec 13, 2016
Revert "Update: Add copy to clipboard for about brave page (fixes #5790)"
@bbondy bbondy reopened this Dec 13, 2016
@bbondy bbondy removed this from the 0.12.15 milestone Dec 13, 2016
@bbondy
Copy link
Member

bbondy commented Dec 13, 2016

reset milestone for now.
This issue is blocked because of:
#6183
And some comments in the PR.

@bbondy bbondy closed this as completed in 5324f3c Dec 13, 2016
@srirambv srirambv added this to the 0.13.0 milestone Dec 14, 2016
bsclifton added a commit that referenced this issue Dec 19, 2016
Redo: Add copy to clipboard for about brave page (fixes #5790)
cezaraugusto pushed a commit that referenced this issue Dec 20, 2016
Closes #6183

Redo PR #6107 (which was reverted with #6184)

- cherry-picked 942e95c
- Added brave.less for about:brave to fix regression on about pages

TODO: Pick up properties from history.less into brave.less

Auditors: @alexwykoff

Test Plan:
1. Visit about:about
@luixxiul
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants