-
Notifications
You must be signed in to change notification settings - Fork 974
about:brave page should have "copy to clipboard" button #5790
Comments
#5693 should be able to cover this as well |
This is a great idea- we're already integrated with a clipboard library, this should be a slam dunk 😄 |
I am trying to get my feet wet with brave code. Can I work on this issue and send my first PR? |
@gyandeeps that would be awesome! I can help you along the way 😄 @bradleyrichter do you have a recommendation of how a "copy to clipboard" button would look? (and where it may go in relation to the current about:brave screen)? edit: |
That FA icon is perfect.
… On Dec 8, 2016, at 10:34 AM, Brian Clifton ***@***.***> wrote:
@gyandeeps that would be awesome!
@bradleyrichter do you have a recommendation of how a "copy to clipboard" button would look? (and where it may go in relation to the current about:brave screen)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Thanks @bsclifton and @bradleyrichter for giving all this info. The only thing left is where shoudl this icon be placed on the about page (top, bottom , etc)? |
How about this? |
looks good to me. I will go with this design as of now unless somebody recommends something else. |
Thanks for volunteering time to this @gyandeeps . I'll have to get my feet wet soon too. |
That would be awesome, @CliqueBait 😄 Let us know if you have any questions |
Update: Add copy to clipboard for about brave page (fixes #5790)
Revert "Update: Add copy to clipboard for about brave page (fixes #5790)"
reset milestone for now. |
Redo: Add copy to clipboard for about brave page (fixes #5790)
Closes #6183 Redo PR #6107 (which was reverted with #6184) - cherry-picked 942e95c - Added brave.less for about:brave to fix regression on about pages TODO: Pick up properties from history.less into brave.less Auditors: @alexwykoff Test Plan: 1. Visit about:about
I like the recent change to version info. It looks cleaner than presenting a dialog. One downside though is that selecting and copying the info gives me this:
Brave 0.12.10
Muon 1.4.26
libchromiumcontent 53.0.2785.143
V8 5.3.332.47
Node.js 6.5.0
Update Channel dev
os.platform linux
os.release 4.8.0-27-generic
os.arch x64
It might be better to add a "copy to clipboard" button which provides something slightly easier to scan when pasted into issue tickets:
Brave: 0.12.10
Muon: 1.4.26
libchromiumcontent: 53.0.2785.143
V8: 5.3.332.47
Node.js: 6.5.0
Update Channel: dev
os.platform: linux
os.release: 4.8.0-27-generic
os.arch: x64
That's basically the text content format of the old dialog.
The text was updated successfully, but these errors were encountered: