Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Clicking "copy to clipboard" buttons need an animation #6297

Closed
bsclifton opened this issue Dec 19, 2016 · 2 comments
Closed

Clicking "copy to clipboard" buttons need an animation #6297

bsclifton opened this issue Dec 19, 2016 · 2 comments

Comments

@bsclifton
Copy link
Member

bsclifton commented Dec 19, 2016

Test Plan:

  1. Visit about:brave
  2. Click Copy to clipboard
  3. Verify copy to clipboard button now shows confirmation label when data is copied.

Original issue details

This is a follow up for #5790

screen shot 2016-12-19 at 10 59 57 am

The copy to clipboard button works great; however, there are no UI behaviors reinforcing the fact that the button was clicked. For example, we could show the word "copied" and fade it in and out. Something to confirm to the user it was copied

For now, I believe this only exists here... but the behavior could be incorporated into our about:styles page (and it could be wrapped with a React component)

cc: @bradleyrichter

@bsclifton bsclifton added accessibility impact/low polish Nice to have — usually related to front-end/visual tasks. labels Dec 19, 2016
@bradleyrichter
Copy link
Contributor

@bsclifton Is this reasonable to implement?

image

The string would appear quickly and fade away.

@bsclifton
Copy link
Member Author

bsclifton commented Dec 19, 2016

@bradleyrichter that looks perfect 😄

Having a div popup there and fade should be easy; would be a great chance to create a re-usable "fading alert" component (or similar)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants