Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

lock icon is sticky in URL bar when it should display search icon #6273

Closed
bradleyrichter opened this issue Dec 16, 2016 · 4 comments
Closed

lock icon is sticky in URL bar when it should display search icon #6273

bradleyrichter opened this issue Dec 16, 2016 · 4 comments
Assignees
@bsclifton
Labels
bug feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.2

Comments

@bradleyrichter
Copy link
Contributor

image
@bradleyrichter bradleyrichter added this to the 1.0.0 milestone Dec 16, 2016
@jkup
Copy link
Contributor

jkup commented Dec 16, 2016

Just a note:

To reproduce you have to go to google.com (which shows the lock) and then start typing a search (which shows the magnifying glass) but then click back to the google.com page. Now if you go to the URL it shows your search text but still shows the lock which it should not.

@bradleyrichter
Copy link
Contributor Author

thanks! I was just having a hard time reproducing this one...

@gyandeeps gyandeeps mentioned this issue Dec 20, 2016
Merged
4 tasks
@srirambv srirambv mentioned this issue Jan 4, 2017
Closed
mrose17 pushed a commit that referenced this issue Jan 6, 2017
@gyandeeps @mrose17
Fix: Url bar icon for search mode (fixes #6273)
763d778
@bsclifton bsclifton modified the milestones: 0.13.1, 1.0.0 Jan 14, 2017
@bsclifton
Copy link
Member

bsclifton commented Jan 18, 2017 •
edited
Loading

Closing as this was fixed with #6319

Test Plan:

  • enable "always show URL bar", to make testing easier
  • go to google.com and notice the lock in the omnibox
  • start typing a search into a the omnibox and notice icon changes to magnifying glass
  • click inside the webpage. icon should stay as magnifying glass and search terms should still be shown. This confirms the fix (the bug before was that it would revert to showing the lock icon next to the search terms)
  • click in the omnibox and press escape. This should reset icon back to lock and reset input back to google.com

@luixxiul
Copy link
Contributor

@bsclifton Thanks for the test plan! 👍

bsclifton pushed a commit that referenced this issue Jan 18, 2017
@gyandeeps @bsclifton
Fix: Url bar icon for search mode (fixes #6273)
d2028be
bsclifton pushed a commit that referenced this issue Jan 18, 2017
@gyandeeps @bsclifton
Fix: Url bar icon for search mode (fixes #6273)
9d038a4
bsclifton pushed a commit that referenced this issue Jan 20, 2017
@gyandeeps @bsclifton
Fix: Url bar icon for search mode (fixes #6273)
5c84d96
NejcZdovc pushed a commit to NejcZdovc/browser-laptop that referenced this issue Jan 23, 2017
@gyandeeps @NejcZdovc
Fix: Url bar icon for search mode (fixes brave#6273)
626ad4d
bsclifton pushed a commit that referenced this issue Jan 23, 2017
@gyandeeps @bsclifton
Fix: Url bar icon for search mode (fixes #6273)
394cd76
bsclifton pushed a commit that referenced this issue Jan 24, 2017
@gyandeeps @bsclifton
Fix: Url bar icon for search mode (fixes #6273)
58f7318
bsclifton pushed a commit that referenced this issue Jan 25, 2017
@gyandeeps @bsclifton
Fix: Url bar icon for search mode (fixes #6273)
388d0c3
bsclifton pushed a commit that referenced this issue Jan 25, 2017
@gyandeeps @bsclifton
Fix: Url bar icon for search mode (fixes #6273)
468f646
This was referenced Feb 3, 2017
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
bug feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.2
Development

No branches or pull requests
7 participants
@aekeus @jkup @bbondy @luixxiul @bsclifton @bradleyrichter @srirambv