Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Make pinned tabs share the same tab content across windows #6413

Closed
bbondy opened this issue Dec 23, 2016 · 5 comments
Closed

Make pinned tabs share the same tab content across windows #6413

bbondy opened this issue Dec 23, 2016 · 5 comments
Assignees
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. feature/pinned-tabs refactoring release-notes/exclude wontfix

Comments

@bbondy
Copy link
Member

bbondy commented Dec 23, 2016

This is expected to fix pinned tab tests

@bbondy bbondy added this to the 0.13.0 milestone Dec 23, 2016
@bbondy bbondy self-assigned this Dec 23, 2016
@bbondy bbondy changed the title Refactor pinned tabs to use an app action Make pinned tabs share the same tab content across windows Dec 24, 2016
@bbondy bbondy modified the milestones: 0.13.1, 0.13.0 Dec 26, 2016
@luixxiul luixxiul modified the milestones: 0.13.3, 0.13.2 Feb 1, 2017
@bbondy bbondy modified the milestones: 0.13.5, 0.13.6 Feb 15, 2017
@alexwykoff alexwykoff added this to the 0.13.6 milestone Mar 9, 2017
@bsclifton
Copy link
Member

moving to 0.13.7

@bsclifton bsclifton modified the milestones: 0.13.7, 0.13.6 Mar 14, 2017
@bbondy bbondy removed this from the 0.14.2 milestone Apr 10, 2017
@bbondy
Copy link
Member Author

bbondy commented Apr 10, 2017

Most of the ground work done here #8084 but probably not happening before 1.0.

@luixxiul luixxiul added this to the 1.0.1 milestone May 29, 2017
@luixxiul luixxiul removed the cr54 label Jul 22, 2017
@alexwykoff alexwykoff modified the milestones: 1.0.1, Backlog Nov 1, 2017
@hugobuddel
Copy link
Contributor

This would be awesome. For most of my pinned tabs it would be fine if they share the same content across windows.

Many of my pinned tabs are chats, and some, like Whatsapp Web, will work only in a single page. So Whatsapp Web will effectively not work as a pinned tab.

Furthermore, it takes about 30 seconds for all my pinned tabs to load, making a new window effectively useless for half a minute, see #13804.

There are some tabs for which it might be useful to have different versions in different windows, e.g. task trackers or so. But I'd rather have all those tabs also share content than none of them like it is now.

@bsclifton bsclifton added stale wontfix addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. and removed stale labels Sep 1, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 1, 2018
@bsclifton
Copy link
Member

Pinned tabs in brave-core should only exist in the window they were pinned on; closing this issue as it should be addressed

@hugobuddel
Copy link
Contributor

Hmm, I like the pinned tabs to be in every window. I use different windows for different 'subjects' and pin things that are always relevant. (I just don't like that it currently is very hard to use a new window until all pinned tabs have loaded.) There seem to be several pinned-tab related extensions for Chrome though, so probably one of them will allow sharing pinned tabs across windows

Is there any way we can already run brave-core? You close many issues, which to me seems a bit premature if it is not possible to run the fixed code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. feature/pinned-tabs refactoring release-notes/exclude wontfix
Projects
None yet
Development

No branches or pull requests

6 participants