To conserve bandwidth do not preload pinned tabs until they are selected on launch

[VirgilRoussos]

A user brought up that preloading the pins on launch could be bad for those without unlimited bandwidth.

I add that it might be also a security issue when connected on some less secured networks.

[psimyn]

related / duplicate of #800 ?

[VirgilRoussos]

I do not think so. It is not a delay, but simply a "do not load until called". However if you feel the two issues can be merged since a single options menu can solve "delay/do not load"

[psimyn]

ah, I thought the delay one was "on-demand load tabs"

[luixxiul]

Not only on launch but also on detach a tab.

[bsclifton]

I believe this will be solved with #13216
cc: @petemill

[petemill]

I don't think #13216 will fix bandwidth per-say, as we are not creating pinned tabs as lazy-loaded (discarded), so muon will still be fetching the content on startup. #13216 should make sure we're not using the window's resources to display the content, however. This could be a simple change to the following, though not sure if it's there for a particular reason - worth testing:

browser-laptop/app/browser/tabs.js

Lines 970 to 977 in 4ae1b6d

	// Tabs are allowed to be initially discarded (unloaded) if they are regular tabs
	// i.e not about: pages, and not pinned
	// and only if the tab creation request passes in `discarded: true`
	const isRegularContent = isHttpOrHttps(createProperties.url)
	const preventLazyLoad = createProperties.pinned || !isRegularContent
	if (preventLazyLoad) {
	createProperties.discarded = false
	}

[bradleyrichter]

The original plan for pinned tabs was that they were to bereferenced across windows and not duplicated. If we can not get to this enhancement, perhaps we should remove the feature of populating pins on all windows - changing it to window-specific pins.

@petemill @bsclifton ?

[bsclifton]

@bradleyrichter w/ regard to multiple pins using same web contents, @bbondy did start work on that type of enhancement when implementing tab detaching... but it wasn't finished

[srirambv]

@bbondy i think this will be fixed in brave-core correct?

cc: @bsclifton

[hugobuddel]

Having the pinned tabs 'be referenced across windows and not duplicated' is what is described in #6413 right? That would be awesome!

The pinned tabs are great, but take like 30 seconds to load on my machine. So I actually started using other browsers more because it's just so much faster to open a new window in them, see #13804.

And to stay within this topic, I noticed this summer that it indeed takes to much bandwidth to use multiple windows with multiple pinned tabs when roaming abroad on 2G.

[NumDeP]

+1 On Chromium if you were to open a dozen bookmarks from a folder in one go, they would all load in task manager wouldn't they, if so, I doubt brave-core fixes this unless you've made changes to this affect.

[bsclifton]

Should be fixed with brave-core