Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Lazy load pinned tabs after tear off tab-to-window #9024

Closed
srirambv opened this issue May 24, 2017 · 3 comments
Closed

Lazy load pinned tabs after tear off tab-to-window #9024

srirambv opened this issue May 24, 2017 · 3 comments
Labels
design A design change, especially one which needs input from the design team. duplicate Issue has already been reported feature/pinned-tabs needs-info Another team member needs information from the PR/issue opener. perf QA/test-plan-specified

Comments

@srirambv
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    yes, but might be a dupe of existing one

  • Describe the issue you encountered:
    Tear off window should not load pinned tabs

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    Brave 0.15.307
    rev 97fb76e
    Muon 3.0.200

  • Steps to reproduce:

    1. Have 10-12 pinned tabs and have two normal tabs
    2. Tear off one the normal tab into a new window
    3. Browser performance slows down as the pinned tabs in the teared off window are also getting loaded while the normal tab is also getting loaded
  • Screenshot if needed:

  • Any related issues:
    Make pinned tabs share the same tab content across windows #6413
    cc: @bsclifton @bbondy @bridiver

@srirambv srirambv added design A design change, especially one which needs input from the design team. feature/pinned-tabs perf QA/test-plan-specified labels May 24, 2017
@luixxiul
Copy link
Contributor

#7631 and #5800?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label May 24, 2017
@srirambv
Copy link
Collaborator Author

srirambv commented May 24, 2017

Its similar to #5800 but that is specific to saying pinned tabs not to be shown in a new window. This is more on retaining the pinned tabs across all windows but not load(or lazy load) on new windows until the pinned is focused.

#804

@bsclifton bsclifton changed the title Tear off tab-to-window should not load pinned tabs Lazy load pinned tabs after tear off tab-to-window May 24, 2017
@bsclifton
Copy link
Member

@srirambv The way it was worded in the title, it sounded covered by #5800. But the real concern is covered by #804 and I believe this is a dupe (ex: #804 would solve this issue too, IMO)

@bsclifton bsclifton added the duplicate Issue has already been reported label May 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. duplicate Issue has already been reported feature/pinned-tabs needs-info Another team member needs information from the PR/issue opener. perf QA/test-plan-specified
Projects
None yet
Development

No branches or pull requests

3 participants