Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Dropdown list has thick left border #6468

Closed
srirambv opened this issue Dec 30, 2016 · 7 comments
Closed

Dropdown list has thick left border #6468

srirambv opened this issue Dec 30, 2016 · 7 comments

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Dropdown list has thick left border

Expected behavior:
Border should be same on all the sides

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):

Brave: 0.13.0 
rev: 0c7a64d6917b6e7e72d074b05e1d7488466418a9 
Muon: 2.0.8 
libchromiumcontent: 54.0.2840.100 
V8: 5.4.500.41 
Node.js: 7.0.0 
Update Channel: dev 
os.platform: win32 
os.release: 10.0.14393 
os.arch: x64
  • Steps to reproduce:

    1. Open any drop down list in pref page all of them have a thick left border
  • Screenshot if needed:
    image

  • Any related issues:
    cc: @bradleyrichter

@srirambv srirambv added polish Nice to have — usually related to front-end/visual tasks. settings release/not-blocking labels Dec 30, 2016
@srirambv srirambv added this to the 0.13.0 milestone Dec 30, 2016
@bbondy
Copy link
Member

bbondy commented Dec 30, 2016

@srirambv can you confirm if this is also present in 0.12.15?

@srirambv
Copy link
Collaborator Author

Here's how it looks on 0.12.15
image

Issue specific to 0.13.0

@bsclifton
Copy link
Member

bsclifton commented Dec 30, 2016

Possible issue details captured here https://bugs.chromium.org/p/chromium/issues/detail?id=395425
I have a fix, working on incorporating it now...

@bsclifton
Copy link
Member

OK it appears this issue is NOT caused by #6258, since it happens when not maximized.

The possible fix I had mentioned above does work (fix being pass Brave.exe two extra params; --high-dpi-support=1 --force-device-scale-factor=1)... but it works by forcing the Brave window to render at 100% DPI. It's important to note that this fix does NOT work at 200% (and also, the window is so small it's unreadable).

The magnification is expected- Chrome 54 introduced that (in 53 and prior, 125% or less DPI were hardcoded to 100%, avoiding this issue completely for those resolutions).

It appears there is a larger issue with DPI which causes this to happen which needs to be investigated.

bsclifton added a commit to brave/muon that referenced this issue Jan 12, 2017
- don't process non-client calcsize/paint
- do proper DPI calculations when DPI > 100%

Fixes brave/browser-laptop#6258

Reverts 182fe6d
Which I believe incorrectly fixed the problem with Chromium 53
(see discussion at electron/electron#7416 for more info)

We need to test to confirm, but I believe this change will fix:
brave/browser-laptop#4502
brave/browser-laptop#6462
brave/browser-laptop#6468
brave/browser-laptop#6481
bsclifton added a commit to brave/muon that referenced this issue Jan 12, 2017
- don't process non-client calcsize/paint
- do proper DPI calculations when DPI > 100%

Auditors: @bbondy, @darkdh

Fixes brave/browser-laptop#6258

Reverts 182fe6d
Which I believe incorrectly fixed the problem with Chromium 53
(see discussion at electron/electron#7416 for more info)

We need to test to confirm, but I believe this change will fix:
brave/browser-laptop#4502
brave/browser-laptop#6462
brave/browser-laptop#6468
brave/browser-laptop#6481
@bsclifton
Copy link
Member

Confirmed this was fixed with brave/muon@30fd6ff 😄

@luixxiul
Copy link
Contributor

Please remove the milestone and add labels QA/no qa needed and release-note/exclude if this appeared and was fixed within the same milestone, thanks!

@bsclifton bsclifton added QA/no-qa-needed release-notes/exclude chromium54 and removed release/not-blocking polish Nice to have — usually related to front-end/visual tasks. settings labels Jan 13, 2017
@bsclifton
Copy link
Member

@luixxiul labels updated; keeping milestone for tracking purposes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants