-
Notifications
You must be signed in to change notification settings - Fork 975
Dropdown list has thick left border #6468
Comments
@srirambv can you confirm if this is also present in 0.12.15? |
Possible issue details captured here https://bugs.chromium.org/p/chromium/issues/detail?id=395425 |
OK it appears this issue is NOT caused by #6258, since it happens when not maximized. The possible fix I had mentioned above does work (fix being pass Brave.exe two extra params; The magnification is expected- Chrome 54 introduced that (in 53 and prior, 125% or less DPI were hardcoded to 100%, avoiding this issue completely for those resolutions). It appears there is a larger issue with DPI which causes this to happen which needs to be investigated. |
- don't process non-client calcsize/paint - do proper DPI calculations when DPI > 100% Fixes brave/browser-laptop#6258 Reverts 182fe6d Which I believe incorrectly fixed the problem with Chromium 53 (see discussion at electron/electron#7416 for more info) We need to test to confirm, but I believe this change will fix: brave/browser-laptop#4502 brave/browser-laptop#6462 brave/browser-laptop#6468 brave/browser-laptop#6481
- don't process non-client calcsize/paint - do proper DPI calculations when DPI > 100% Auditors: @bbondy, @darkdh Fixes brave/browser-laptop#6258 Reverts 182fe6d Which I believe incorrectly fixed the problem with Chromium 53 (see discussion at electron/electron#7416 for more info) We need to test to confirm, but I believe this change will fix: brave/browser-laptop#4502 brave/browser-laptop#6462 brave/browser-laptop#6468 brave/browser-laptop#6481
Confirmed this was fixed with brave/muon@30fd6ff 😄 |
Please remove the milestone and add labels |
@luixxiul labels updated; keeping milestone for tracking purposes |
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Dropdown list has thick left border
Expected behavior:
Border should be same on all the sides
Platform (Win7, 8, 10? macOS? Linux distro?):
Windows 10 x64
Brave Version (revision SHA):
Steps to reproduce:
Screenshot if needed:
Any related issues:
cc: @bradleyrichter
The text was updated successfully, but these errors were encountered: