Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Building Brave on Windows causes generic Electron window to appear #6481

Closed
jkup opened this issue Dec 31, 2016 · 6 comments
Closed

Building Brave on Windows causes generic Electron window to appear #6481

jkup opened this issue Dec 31, 2016 · 6 comments
Labels
OS/Windows QA/no-qa-needed release-notes/exclude
Milestone
0.13.0

Comments

@jkup
Copy link
Contributor

jkup commented Dec 31, 2016

Did you search for similar issues before submitting this one?
Yes.

Describe the issue you encountered:
When you npm run watch && npm start on Windows it starts Brave but also opens the generic Electron window (screenshot below).

Expected behavior:
It should start Brave and not show the Electron window.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Win10

  • Brave Version (revision SHA):
    master

  • Steps to reproduce:

    1. Build Brave on Windows
    2. npm run watch-all && npm start
    3. notice two windows open, Brave and Electron.

  • Screenshot if needed:
    capture

  • Any related issues:
bsclifton added a commit to brave/muon that referenced this issue Jan 12, 2017
@bsclifton
Properly fix border issues
cf31c00 
- don't process non-client calcsize/paint
- do proper DPI calculations when DPI > 100%

Fixes brave/browser-laptop#6258

Reverts 182fe6d
Which I believe incorrectly fixed the problem with Chromium 53
(see discussion at electron/electron#7416 for more info)

We need to test to confirm, but I believe this change will fix:
brave/browser-laptop#4502
brave/browser-laptop#6462
brave/browser-laptop#6468
brave/browser-laptop#6481
bsclifton added a commit to brave/muon that referenced this issue Jan 12, 2017
@bsclifton
Properly fix border issues
30fd6ff 
- don't process non-client calcsize/paint
- do proper DPI calculations when DPI > 100%

Auditors: @bbondy, @darkdh

Fixes brave/browser-laptop#6258

Reverts 182fe6d
Which I believe incorrectly fixed the problem with Chromium 53
(see discussion at electron/electron#7416 for more info)

We need to test to confirm, but I believe this change will fix:
brave/browser-laptop#4502
brave/browser-laptop#6462
brave/browser-laptop#6468
brave/browser-laptop#6481
@bsclifton
Copy link
Member

bsclifton commented Jan 12, 2017 •
edited
Loading

This appears to be fixed as of brave/muon@30fd6ff. Once we have a new prebuilt, let's re-test 😄

@bsclifton
Copy link
Member

Closing this for now; I got latest in browser-laptop-bootstrap and it's no longer happening

@luixxiul
Copy link
Contributor

Please remove the milestone and add labels QA/no qa needed and release-note/exclude if this appeared and was fixed within the same milestone, thanks!

@bsclifton bsclifton added this to the 0.13.0 milestone Jan 13, 2017
@bsclifton
Copy link
Member

@luixxiul labels updated; keeping milestone for tracking purposes

@bsclifton
Copy link
Member

Per @darkdh, this should have been fixed by brave/muon@99dff28 😄

@luixxiul
Copy link
Contributor

Sweet!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
OS/Windows QA/no-qa-needed release-notes/exclude
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
3 participants
@jkup @luixxiul @bsclifton