-
Notifications
You must be signed in to change notification settings - Fork 974
wallet preference page is not refreshing itself when a bitcoin handler is registered #6770
Comments
Confirmed on 0.13.0 RC4 on Windows 10 32 bit |
the issue appears to be that updateAboutDetails is invoked when a tab is created, but not when you switch to it. looking at earlier versions, e.g., https://github.com/brave/browser-laptop/blob/0_12_14_release_notes/js/components/frame.js#L93 it looks like a looser test was used. @bbondy - |
howdy mrose, you'll have to pass in props for if it's registered, I'm a bit concerned about a perf problem here though. Maybe we should add an event when a protocol is registered and handle it? @bridiver |
@bbondy - i am sensitive to the performance issue. since this code is 90% browser internals and 10% ledger-related, i'd like to have it re-assigned to someone who knows the internals and can make a performant/correct fix. |
Resolves brave#6770 Auditors: @alexwykoff @bsclifton @mrose17 Test Plan: - described in brave#6770
Fixed wallet preference page refresh
Working on 0.13.5 RC3 |
Test plan
From #7443 (comment)
Original issue description
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
When executing the ledger regression tests, it was found that https://jsfiddle.net/LnwtLckc/5/ did not appear to have registered appropriately. Upon further investigation, it was discovered that the real issue was that the preference page was not updating when the handler was being registered/unregistered like it had in prior releases.
Platform (Win7, 8, 10? macOS? Linux distro?):
Tested on OS X
Brave Version (revision SHA):
0.13.0 Preview 10 (c60b783)
Steps to reproduce:
Actual result:
'transfer btc' button does not appear in the modal
Expected result:
'transfer btc' button should appear in the modal
Will the steps above reproduce in a fresh profile? If not what other info can be added?
yes
Is this an issue in the currently released version?
no
Can this issue be consistently reproduced?
yes
Extra QA steps:
1.
2.
3.
Screenshot if needed:
Any related issues:
The text was updated successfully, but these errors were encountered: