This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fixed wallet preference page refresh #7443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves brave#6770 Auditors: @alexwykoff @bsclifton @mrose17 Test Plan: - described in brave#6770
mrose17
approved these changes
Mar 2, 2017
bsclifton
approved these changes
Mar 2, 2017
bsclifton
added
QA/test-plan-specified
release-notes/include
and removed
PR/ready-for-merge
labels
bridiver
reviewed
Mar 2, 2017
| fn(ses, partition, module.exports.isPrivate(partition)) | ||
| }) | ||
| ses.on('register-navigator-handler', (e, protocol, location) => { | ||
| appActions.navigatorHandler(ses.partition, protocol, location, true) |
There was a problem hiding this comment.
we should try to keep the declarative naming conventions here so maybe navigatorHandlerRegistered and navigatorHandlerUnregistered?
There was a problem hiding this comment.
Good call 👍 Since this is already merged, please feel free to do as a follow up, @NejcZdovc 😄
bridiver
reviewed
Mar 2, 2017
| @@ -232,6 +232,11 @@ const doAction = (action) => { | |||
| setTimeout(networkConnected, 1 * msecs.second) | |||
| break | |||
|
|
|||
| case appConstants.APP_NAVIGATOR_HANDLER_UPDATE: | |||
There was a problem hiding this comment.
related to the above comment, the app constant name should match the action name
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this pull request
Mar 3, 2017
Auditors: @bridiver @bsclifton Test Plan:
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this pull request
Mar 3, 2017
Auditors: @bridiver @bsclifton Test Plan:
Merged
bridiver
added a commit
that referenced
this pull request
Mar 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Resolves #6770
Auditors:
@alexwykoff @bsclifton @mrose17
Test plan