Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

remove redundant dateline in contributions PDF #6896

Closed
mrose17 opened this issue Jan 27, 2017 · 3 comments
Closed

remove redundant dateline in contributions PDF #6896

mrose17 opened this issue Jan 27, 2017 · 3 comments
Assignees
@mrose17
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.5

Comments

@mrose17
Copy link
Member

mrose17 commented Jan 27, 2017 •
edited by bsclifton
Loading

Test Plan

  • either have a payment history or generate one with npm run add-simulated-payment-history
  • open Brave -> Preferences -> Payments (or navigate to about:preferences#payments)
  • click "View Payment History"
  • open your first payment receipt PDF
  • observe there is no date range present
  • open a later payment receipt PDF
  • observe a time range is present

Original issue description

here is what we have now:

0

the last line was intended to give a timeframe, but is redundant, so remove it!
@mrose17 mrose17 added this to the 0.13.2 milestone Jan 27, 2017
@mrose17 mrose17 self-assigned this Jan 27, 2017
@mrose17 mrose17 mentioned this issue Jan 27, 2017
Closed
@mrose17
Copy link
Member Author

mrose17 commented Jan 29, 2017

Closed in response to useful feedback!

@mrose17 mrose17 closed this as completed Jan 29, 2017
@luixxiul luixxiul removed this from the 0.13.2 milestone Jan 29, 2017
@willy-b willy-b mentioned this issue Jan 30, 2017
Merged
2 tasks
@willy-b
Copy link
Contributor

willy-b commented Jan 30, 2017

I opened a new PR for this in #6933 per discussion with @mrose17 in https://github.com/willy-b/browser-laptop/commit/a510c87d1598b6e75043bf2924e36643355e4e7e#commitcomment-20667505 and his PR #6897

@willy-b willy-b reopened this Jan 30, 2017
@mrose17 mrose17 added this to the 0.13.2 milestone Jan 31, 2017
@bbondy bbondy modified the milestones: 0.13.3, 0.13.2 Feb 1, 2017
bsclifton added a commit that referenced this issue Feb 16, 2017
@bsclifton
Merge pull request #6933 from willy-b/issue-6897
8222db4 
only display time range in statement PDF when range is available (#6896, #6897)
@bsclifton
Copy link
Member

Fixed with #6933

This was referenced Feb 26, 2017
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 3, 2017
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrose17 mrose17

Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.5
Development

No branches or pull requests
7 participants
@mrose17 @bbondy @alexwykoff @luixxiul @bsclifton @willy-b @srirambv