-
Notifications
You must be signed in to change notification settings - Fork 973
Remove contribution range from PDF statement #6897
Conversation
note: this does give a range if the current contribution is not your first one (then it is not redundant). not disagreeing with change, just giving context :-). |
Maybe keep it and only display it when range is available? |
@NejcZdovc - you've convinced me. i'm going to withdraw this issue and the PR. could you make the line more useful? i'm also not really keen on the design placement either, but that's another matter! |
@willy-b can you tackle this? |
@NejcZdovc sure, happy to! |
@mrose17 , I fixed this as per @NejcZdovc's suggestion (https://github.com/willy-b/browser-laptop/commit/a510c87d1598b6e75043bf2924e36643355e4e7e). Example: Two consecutive statements should I open a new PR against #6896? |
note: @mrose17 responded to my question in a comment on my commit (https://github.com/willy-b/browser-laptop/commit/a510c87d1598b6e75043bf2924e36643355e4e7e#commitcomment-20667505): so, opening a separate PR |
Fixes #6896
Auditor: @bsclifton
Test Plan: