Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Autofill offset is off on torproject.com #7033

Closed
bbondy opened this issue Feb 3, 2017 · 5 comments · Fixed by #7083
Closed

Autofill offset is off on torproject.com #7033

bbondy opened this issue Feb 3, 2017 · 5 comments · Fixed by #7083

Comments

@bbondy
Copy link
Member

bbondy commented Feb 3, 2017

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    Using a previously saved brave user/password on https://trac.torproject.org/projects/tor/login shows the drop down above the box instead of below.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version (revision SHA):
    0.13.2-RC2
    ce14f5d

  • Steps to reproduce:

    1. Go to https://trac.torproject.org/projects/tor/login
    2. type in a username and wrong password
    3. type in username again
  • Actual result:
    context menu shows at the wrong position above the input box.

  • Expected result:
    context menu should show underneath the input box.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Screenshot if needed:

screenshot 2017-02-03 11 08 09

@bbondy
Copy link
Member Author

bbondy commented Feb 3, 2017

To make matters worse if you have 2 saved things, it will cover up the input:

screenshot 2017-02-03 11 11 14

@srirambv
Copy link
Collaborator

srirambv commented Feb 3, 2017

On Windows
image

@darkdh
Copy link
Member

darkdh commented Feb 5, 2017

screen shot 2017-02-05 at 23 19 08

0.13.2 RC4

@darkdh darkdh added this to the 0.13.2 milestone Feb 5, 2017
@darkdh darkdh self-assigned this Feb 5, 2017
@darkdh
Copy link
Member

darkdh commented Feb 5, 2017

Updated STR:

  1. Toggle clear download history when close Brave
  2. Download something to make download tool bar shows
  3. Quit Brave when downloading
  4. After relaunch brave go to https://github.com/brave/browser-laptop/issues
  5. Search something on filter to make autofill popup
  6. The popup will be shifted

darkdh added a commit to darkdh/browser-laptop that referenced this issue Feb 5, 2017
fix brave#7033

Auditors: @bbondy

Test Plan:

1. Toggle clear download history when close Brave
2. Download something to make download tool bar shows
3. Quit Brave when downloading
4. After relaunch brave go to https://github.com/brave/browser-laptop/issues
5. Search something on filter to make autofill popup
6. The popup shouldn't be shifted
@luixxiul
Copy link
Contributor

luixxiul commented Feb 5, 2017

Related: #3758

darkdh added a commit to darkdh/browser-laptop that referenced this issue Feb 5, 2017
fix brave#3758
fix brave#7033

Auditors: @bbondy

Test Plan:

1. Toggle clear download history when close Brave
2. Download something to make download tool bar shows
3. Quit Brave when downloading
4. After relaunch brave go to https://github.com/brave/browser-laptop/issues
5. Search something on filter to make autofill popup
6. The popup shouldn't be shifted
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.