This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Strengthen the download toolbar visible condition just like main.js #7083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix brave#3758 fix brave#7033 Auditors: @bbondy Test Plan: 1. Toggle clear download history when close Brave 2. Download something to make download tool bar shows 3. Quit Brave when downloading 4. After relaunch brave go to https://github.com/brave/browser-laptop/issues 5. Search something on filter to make autofill popup 6. The popup shouldn't be shifted
|
Yes, it shifts 50px. I will add auto closing to commit. |
|
++ nice find |
luixxiul
added
feature/autofill
feature/download
and removed
PR/needs-QA-attention ☕
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3758
fix #7033
Auditors: @bbondy
Test Plan:
git rebase -ito squash commits (if needed).