Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed torrent name missing after download is started #7362

Closed
feross opened this issue Feb 23, 2017 · 2 comments
Closed

Fixed torrent name missing after download is started #7362

feross opened this issue Feb 23, 2017 · 2 comments

Comments

@feross
Copy link
Contributor

feross commented Feb 23, 2017

Test plan

  1. Click any magnet link from https://codepen.io/ferossity/full/qaezaB/
  2. Click "Start Download" to start the torrent
  3. Ensure that the torrent title shows up at the top of the page

Original issue description

  • Did you search for similar issues before submitting this one? Yes

  • Describe the issue you encountered: The name of the torrent shows up when asking the user to confirm whether to start the download, but it doesn't show up after the download has started, which is confusing, especially when coming back to the tab.

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS

  • Brave Version (revision SHA): 71d8ffc

  • Steps to reproduce:

    1. Start WIRED torrent download from https://codepen.io/ferossity/pen/qaezaB
    2. Click "start"
    3. See that title is missing now
  • Actual result: Title is missing

  • Expected result: Title should show up

  • Will the steps above reproduce in a fresh profile? If not what other info can be added? YEs.

  • Is this an issue in the currently released version? Yes.

  • Can this issue be consistently reproduced? Yes.

  • Screenshot if needed:

Before starting, title shows:

screen shot 2017-02-23 at 2 21 46 pm

After starting, title is missing:

screen shot 2017-02-23 at 2 21 53 pm

@feross feross self-assigned this Feb 23, 2017
@feross feross added this to the 0.13.5 milestone Feb 23, 2017
feross added a commit that referenced this issue Feb 23, 2017
The name of the torrent shows up when asking the user to confirm
whether to start the download, but it doesn't show up after the
download has started, which is confusing, especially when coming back
to the tab.

Fixes: #7362
@bbondy bbondy modified the milestones: 0.13.5, 0.13.6 Feb 28, 2017
@alexwykoff alexwykoff mentioned this issue Mar 14, 2017
44 tasks
@bsclifton
Copy link
Member

Moving to 0.14.1

@srirambv
Copy link
Collaborator

Tab title changes only on mouse over/away similar to #7765. But works.

@alexwykoff alexwykoff changed the title Torrent name is missing once download is started Fixed torrent name missing after download is started Mar 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.