Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Torrent name is missing once download is started #7364

Merged
merged 1 commit into from
Mar 19, 2017
Merged

Conversation

feross
Copy link
Contributor

@feross feross commented Feb 23, 2017

The name of the torrent shows up when asking the user to confirm
whether to start the download, but it doesn't show up after the
download has started, which is confusing, especially when coming back
to the tab.

Fixes: #7362

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

  1. Click any magnet link from https://codepen.io/ferossity/full/qaezaB/
  2. Click "Start Download" to start the torrent
  3. Ensure that the torrent title shows up at the top of the page

The name of the torrent shows up when asking the user to confirm
whether to start the download, but it doesn't show up after the
download has started, which is confusing, especially when coming back
to the tab.

Fixes: #7362
@feross
Copy link
Contributor Author

feross commented Mar 17, 2017

This is a pretty simple change – anyone want to review before I merge?

@bsclifton
Copy link
Member

@feross I'll definitely check it out soon

@bsclifton bsclifton added this to the 0.14.0 milestone Mar 18, 2017
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out, looks good ++ 😄

@srirambv
Copy link
Collaborator

Tested and works fine.
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants