Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update to Standard@9.0.0 - rules "no-multiple-empty-lines", "no-useless-return", "generator-star-spacing", "padded-blocks" #7492

Closed
4 tasks done
cezaraugusto opened this issue Mar 4, 2017 · 0 comments · Fixed by #7495

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Mar 4, 2017

Test plan

#7495 (comment)


Version 9.0.0 introduced major changes that changed lint rules for several files.

This work will be split to avoid regressions. From Standard changelog those rules were added:

(note that changed rules didn't affect our repo)

  • Disallow mixing different operators without parens (no-mixed-operators)
  • Enforce 1 newline at end of file (previously 1 or 2 were ok) (no-multiple-empty-lines)
  • Disallow Unused Expressions (no-unused-expressions)
  • Disallow redundant return statements (no-useless-return)
  • Disallow Incorrect Early Use (no-use-before-define)
  • Enforce that Promise rejections are passed an Error object as a reason (prefer-promise-reject-errors)
  • Enforce comparing typeof expressions against string literals (valid-typeof)
  • Enforce spacing around * in generator functions (generator-star-spacing)
  • Disallow Unnecessary Labels (no-extra-label)
  • Disallow spacing between template tags and their literals (template-tag-spacing)
  • Disallow padding within switch statements and classes (padded-blocks)
  • Enforce that Symbols are passed a description (symbol-description)

This issue addresses rules marked as checked.

@cezaraugusto cezaraugusto added this to the 0.13.6 milestone Mar 4, 2017
@cezaraugusto cezaraugusto self-assigned this Mar 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.