This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Update Standard@9.0.0 #7817
Merged
Update Standard@9.0.0 #7817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
how Travis handle deps updates? I think we can update this to match current Travis version |
|
@cezaraugusto i think there is a bug in how travis invalidates caches; others report similar issues at travis-ci/travis-ci#3758. i'm not sure if shrinkwrapping helps but it might. |
|
anyway i reverted caching on master for now |
bsclifton
referenced
this pull request
in darkdh/browser-laptop
Mar 28, 2017
fix brave#7916 Auditors: @bbondy, @bsclifton Test Plan: - Make sure automated tests are passing - `npm run test -- --grep=adBlockUtil` - Make sure you don't see ads on YouTube. - Make sure `http://downloadme.org/` will be reported as malicious site
4 tasks
Auditors: @bsclifton Fix #7813 Follow-up of: #7495 and #7785 Test Plan: `npm run lint` should throw no errors
Fix broken unit test Auditors: @cezaraugusto
bsclifton
approved these changes
Apr 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditors: @bsclifton
Fix #7492
Follow-up of #7495 and #7785
Will also help with standard version inconsistency between repo/travis (#7794)
This PR addressed the following new rules:
Test plan:
npm run lint