Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update lint style for Standard@9.0.0 - first patch #7495

Merged
merged 1 commit into from
Mar 13, 2017
Merged

Update lint style for Standard@9.0.0 - first patch #7495

merged 1 commit into from
Mar 13, 2017

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Mar 4, 2017

Auditors: @bsclifton, @NejcZdovc
Fix #7492

This PR addressed the following new rules:

no-multiple-empty-lines
no-useless-return
generator-star-spacing
padded-blocks

Test plan (two steps):

  1. With current standard, run
npm run lint
  • There should be no linting errors
  1. Update standard@9.0.0
  • Lint errors should not include:
    • Too many blank lines at the end of file...
    • Unnecessary return statement
    • Expected indentation of...
    • Missing space after *
    • Block must not be padded by blank lines

Note: Most files were updated running standard --fix. Below files that were updated manually:

main.js (code commented as a reference)
settings.js
dataFile.js

@cezaraugusto cezaraugusto added this to the 0.13.6 milestone Mar 4, 2017
@cezaraugusto cezaraugusto self-assigned this Mar 4, 2017
@bsclifton
Copy link
Member

We're going to want to bump up the version of standard in the package.json also

@cezaraugusto
Copy link
Contributor Author

if we bump now there will be several lint errors that are still unfixed by this PR. Plan is doing changes based on a group of rules, and only update standard when all new rules are properly lint.

@bsclifton
Copy link
Member

That sounds good :)

Auditors: @bsclifton, @NejcZdovc
Fix #7492

Added lint for below rules:

* no-multiple-empty-lines
* no-useless-return
* generator-star-spacing
* padded-blocks
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄 I went ahead and rebased; will merge now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants