-
Notifications
You must be signed in to change notification settings - Fork 974
Use npm shrinkwrap and travis caching #7795
Conversation
Docs for reference (I've never used shrinkwrap- need to look more into it) - https://docs.npmjs.com/cli/shrinkwrap This would make the updating processing interesting. I'm also curious if it'll work OK across platforms (Windows, Linux, macOS) |
f6d75a9
to
234fcf1
Compare
fyi I opened a PR to update standard@9 that could help as well: #7817 so repo/travis can share the same version |
sorry just saw Yan comment on ref PR. I'm curious why Travis isn't matching repo's deps version. |
@diracdeltas would you be able to run I think this PR solves the problem in a much more standard way than #8283. Sorry I had been hesitant to accept it- this would be a great one 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment in #8283 (comment). I think that we need this PR for travis caching, so that we can speed up our test's.
This reverts commit 8983c67.
234fcf1
to
84f610b
Compare
updated shrinkwrap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ 😄
@@ -22,6 +22,7 @@ Brave welcomes contributions via [pull requests](https://github.com/brave/browse | |||
Fix #206 | |||
```` | |||
|
|||
* If you update the npm dependencies, run `npm shrinkwrap --dev` before committing changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: is it ok to run that everytime when I commit something to keep the dependencies up to date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luixxiul we'll want to pick and choose the times we update dependencies. Unless there is a good reason (need new version to get a feature, we're too out of date, etc) , we should stick with the version there. This is important to stabilize the codebase.
Any updates we do to libraries we use may require a small regression test to ensure the upgrade didn't break any functionality or introduce issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsclifton thanks!
With the fix to a non-existent self.state.properties Fixes #8423
fix #7820
git rebase -i
to squash commits (if needed).Test Plan: