Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

URL bar suggestions can only be navigated using down key when suggestion list is shown #7682

Closed
srirambv opened this issue Mar 13, 2017 · 0 comments
Labels
accessibility parity Features which should be supported in Brave since they're supported in other major browsers. polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified

Comments

@srirambv
Copy link
Collaborator

srirambv commented Mar 13, 2017

Test plan

  1. Ensure all suggestions switch is enabled in the search setting page
  2. Have sufficient history so that suggestion are shown based on all the options
  3. Try using UP arrow key to select the bottom most suggestion list, it works now

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    URL bar suggestions can only be navigated using down key when suggestion list is shown

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    Brave 0.13.5
    rev 1db81cb

  • Steps to reproduce:

    1. Ensure all suggestions switch is enabled in the search setting page
    2. Have sufficient history so that suggestion are shown based on all the options
    3. Try using UP arrow key to select the bottom most suggestion list, doesn't work. Have to scroll down or use a mouse to open the suggested item
  • Actual result:
    Press UP arrow doesn't select the last suggestion

  • Expected result:
    Navigation should be both ways using UP and Down arrow key on URL bar suggestions

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    downarrow

  • Any related issues:

@srirambv srirambv added accessibility parity Features which should be supported in Brave since they're supported in other major browsers. polish Nice to have — usually related to front-end/visual tasks. QA/test-plan-specified labels Mar 13, 2017
@srirambv srirambv added this to the contributor backlog milestone Mar 13, 2017
josiah-keller pushed a commit to josiah-keller/browser-laptop that referenced this issue Apr 28, 2017
@luixxiul luixxiul removed this from the contributor backlog milestone Apr 29, 2017
@bsclifton bsclifton added this to the 0.15.2 milestone Apr 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility parity Features which should be supported in Brave since they're supported in other major browsers. polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified
Projects
None yet
Development

No branches or pull requests

4 participants