Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Make up/down arrow keys wrap to other end in urlbar suggestions #8546

Merged
merged 1 commit into from
Apr 29, 2017

Conversation

josiah-keller
Copy link
Contributor

@josiah-keller josiah-keller commented Apr 28, 2017

Test plan

  1. Ensure all suggestions switch is enabled in the search setting page
  2. Have sufficient history so that suggestion are shown based on all the options
  3. Try using UP arrow key to select the bottom most suggestion list, it works now

Description

Fix #7682

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Copy link

@cndouglas cndouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@bsclifton
Copy link
Member

bsclifton commented Apr 29, 2017

@josiah-keller could you add some steps for testing? You can edit your original post above and then we can copy into the issue

edit: I created some steps which might be good- take a peek, let me know 😄

@bsclifton bsclifton added this to the 0.15.2 milestone Apr 29, 2017
@bsclifton
Copy link
Member

Change looks great! Thanks 😄

@bsclifton bsclifton merged commit 27763d6 into brave:master Apr 29, 2017
@josiah-keller josiah-keller deleted the urlbar-wrap branch April 29, 2017 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants