Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added lion icon badge #7859

Closed
NejcZdovc opened this issue Mar 23, 2017 · 2 comments
Closed

Added lion icon badge #7859

NejcZdovc opened this issue Mar 23, 2017 · 2 comments

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Mar 23, 2017

Test Plan

  • go to youtube
  • play some videos
  • check if licon badge has the same number as shield panel

Original issue description

We would like to add badge to the lion icon in the top right. Badge will display how many ads and trackers were blocked on a current site

8f0fe246-ed3a-11e6-9e97-92e1cfcaa539

@NejcZdovc NejcZdovc added this to the 0.14.1 milestone Mar 23, 2017
@NejcZdovc NejcZdovc self-assigned this Mar 23, 2017
@bsclifton bsclifton changed the title Lion icon bandge Lion icon badge Mar 23, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 23, 2017
Resolves brave#7859

Auditors: @bradleyrichter @jonathansampson @bsclifton

Test Plan:
- go to youtube
- play some videos
- check if licon badge has the same number as shield panel
@NejcZdovc NejcZdovc mentioned this issue Mar 23, 2017
4 tasks
@NejcZdovc
Copy link
Contributor Author

Suggestion by @jonathansampson:

  1. Counter-tab is visible once page begins loading.
  2. As resources are blocked, the number increments out in the open.
  3. Once the page is done loading, the Counter-tab slides in behind the Icon.
  4. The Counter-tab is revealed on hover.

Demo: https://jsfiddle.net/eh6rmLy6/3/

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 23, 2017
Resolves brave#7859

Auditors: @bradleyrichter @jonathansampson @bsclifton

Test Plan:
- go to youtube
- play some videos
- check if licon badge has the same number as shield panel
bsclifton added a commit that referenced this issue Mar 23, 2017
@bsclifton bsclifton modified the milestones: 0.14.0, 0.14.1 Mar 23, 2017
@luixxiul
Copy link
Contributor

Adding min-width:7px makes the badge square.

screenshot 2017-03-24 11 00 58

I think this is better. what do you think?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.