Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Adds lion badge #7861

Merged
merged 1 commit into from
Mar 23, 2017
Merged

Adds lion badge #7861

merged 1 commit into from
Mar 23, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 23, 2017

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #7859

Auditors

@bradleyrichter @jonathansampson @bsclifton

Test Plan

  • go to youtube
  • play some videos
  • check if licon badge has the same number as shield panel

Resolves brave#7859

Auditors: @bradleyrichter @jonathansampson @bsclifton

Test Plan:
- go to youtube
- play some videos
- check if licon badge has the same number as shield panel
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🦁 Big ++ for the test too

@bsclifton bsclifton merged commit 4cc431b into brave:master Mar 23, 2017
@bsclifton bsclifton modified the milestones: 0.14.0, 0.14.1 Mar 23, 2017
NejcZdovc added a commit that referenced this pull request Mar 26, 2017
Issue was introduced with #7861

Auditors: @bsclifton @jonathansampson

Test Plan:
- start browser with a fresh profile
- there shouldn't be any erros or white screen
bsclifton pushed a commit that referenced this pull request Mar 26, 2017
Issue was introduced with #7861

Auditors: @bsclifton @jonathansampson

Test Plan:
- start browser with a fresh profile
- there shouldn't be any erros or white screen
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants