This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 973
When writing session to disk, ensure we do a flush #7876
Comments
10 tasks
We can use this API for doing the write: |
|
bridiver
added a commit
that referenced
this issue
May 1, 2017
4 tasks
bridiver
added a commit
that referenced
this issue
May 1, 2017
bridiver
added a commit
that referenced
this issue
May 1, 2017
bridiver
added a commit
that referenced
this issue
May 1, 2017
bridiver
added a commit
that referenced
this issue
May 2, 2017
This was referenced May 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
per discussion with @bridiver:
We'll want to use
fs.fsync
when savingsession-store-1
to disk. We've had problems with this file being corrupted when a BSOD happens on Windows. The save that happens every 5 mins may not have been flushed.Notes from the discussion:
writeSync
doesn’t force a sync to diskMOVEFILE_WRITE_THROUGH
flagThe text was updated successfully, but these errors were encountered: