This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
use write.writeImportant for session store #8593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
force-pushed
the
session-store-save
branch
2 times, most recently
from
a765517 to
7883a67
Compare
bridiver
force-pushed
the
session-store-save
branch
from
7883a67 to
40abc0c
Compare
|
++ |
bsclifton
reviewed
May 2, 2017
| } | ||
| return p | ||
| } | ||
|
|
||
| /** | ||
| * Clears all session cache. | ||
| * @return a promise that always resolves (called on app shutdon so must always) |
There was a problem hiding this comment.
should be updated; doesn't return a promise anymore
There was a problem hiding this comment.
yep, that's true for several of these now
| for (let partition in registeredSessions) { | ||
| let ses = registeredSessions[partition] | ||
| p = p.then(promisify(ses.clearCache.bind(ses)).catch(() => {})) | ||
| setImmediate(ses.clearCache.bind(ses)) |
There was a problem hiding this comment.
Since there are docs on the Muon side, I think it would be helpful to put a link to the docs as a comment; ex:
https://github.com/brave/muon/blob/master/docs/api/session.md#sesclearcachecallback
(and if needed, update the docs)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7876
git rebase -ito squash commits (if needed).Test Plan:
quit/restart behavior when updating