Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

fix radii, colors, focused state styles in URL bar related to new add-funds button #8058

Closed
bradleyrichter opened this issue Apr 3, 2017 · 0 comments
Closed

fix radii, colors, focused state styles in URL bar related to new add-funds button #8058

bradleyrichter opened this issue Apr 3, 2017 · 0 comments
Assignees
@NejcZdovc
Labels
bug feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.15.0

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Apr 3, 2017 •
edited by NejcZdovc
Loading

  1. box radius should be either 0px or 4px depending on presence of add-funds button

image

  1. also change focus-indicator inner shadow radius to match Basic tab structure #1.

image

  1. Change focus-indicator style from inner shadow to 2px inside border.

image

image

  1. RGB value of add-funds button border should match RGB of bookmark button.

image

  1. Fix border not being full width. More info here: Follow-up of #7547 (Update the top panel) #7740 (review)
@bradleyrichter bradleyrichter added this to the 0.14.2 milestone Apr 3, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 3, 2017
@NejcZdovc
Various URL bar related design fixes
8d8a749 
Resolves brave#8058

Auditors: @bradleyrichter @bsclifton

Test Plan:
- specified in brave#8058
@NejcZdovc NejcZdovc mentioned this issue Apr 3, 2017
Merged
4 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 4, 2017
@NejcZdovc
Various URL bar related design fixes
94e02ef 
Resolves brave#8058

Auditors: @bradleyrichter @bsclifton

Test Plan:
- specified in brave#8058
bsclifton added a commit that referenced this issue Apr 4, 2017
@bsclifton
Merge pull request #8059 from NejcZdovc/hotfix/#8058-url
becdbba 
Various URL bar related design fixes
This was referenced Apr 9, 2017
Closed
Closed
Closed
Closed
This was referenced Apr 13, 2017
Closed
Closed
Closed
This was referenced Apr 21, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
@alexwykoff alexwykoff changed the title fix radii, colors, focused state styles in URL bar related to new add-funds button Fixed styles in URL bar related to new add-funds button Apr 25, 2017
@luixxiul luixxiul changed the title Fixed styles in URL bar related to new add-funds button fix radii, colors, focused state styles in URL bar related to new add-funds button Oct 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
7 participants
@alexwykoff @luixxiul @cezaraugusto @bsclifton @NejcZdovc @bradleyrichter @srirambv