Basic tab structure

[KevinGrandon]

No description provided.

[bbondy]

Obviously still a lot of unhooked parts, but definitely a step towards the right direction.

One thing I'd like to see changed before landing is to move the state outside of tabs.js.
State would change in ui.tabs.

Ideally we'll have all components with no state inside of them and fully loaded from prop changes.

[KevinGrandon]

State for tab dragging and dropping? We can move that out.

It seems like it might be a lot of work to have state in ui.tabs, wouldn't we need to synchronize that with the frames as well?

How do we feel about tacking on additional data to each frame? E.g., frames.[n].tabIsDragging|tabIsDraggingOverLeftHalf|tabIsDraggingOverRightHalf

[bbondy]

As silly as it sounds for this case, yes I was hoping that we could have fully referentially transparent components. Please spend a few minutes to read this to see if it might change your mind. I could see doing an exception here leading to doing exceptions elsewhere. The hope would be to change partially or fully to React stateless components which they stated in 0.14 release notes that there would be further performance optimizations related to them.

Note that ImmutableComponent doesn't even consider state for detecting changes right now.
https://github.com/brave/browser-electron/blob/master/js/components/immutableComponent.js

I don't think it would be that hard to do the state changes in the store, it would just require a single action which can manage each of those 3 states.

I won't try to stop you from landing, but I'd like to give stateless components a shot.

[KevinGrandon]

I agree that we should move the state out, just trying to figure out the right place for it :)

Should it go into ui.tabs or be tacked onto each frame? If we put it on ui.tabs, then we'd need to synchronize the tabs for each frame operation that we do currently right? (Adding/removing/crashing/etc)

[bbondy]

If we put it on ui.tabs, then we'd need to synchronize the tabs for each frame operation that we do currently right? (Adding/removing/crashing/etc)

hrm not sure I see why, can you explain? Also let me know what you mean by synchronize, might be better for a slack cha if you want higher bandwidth discussion.

[bbondy]

I wonder if left + right could just be combined into a single action with different params?

[bbondy]

OK going to merge this in, feel free to do the follow ups if you agree in an audit.