Saved address doesn't show under about:autofill but shows suggestion on forms

[srirambv]

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Saved address doesn't show under about:autofill but shows suggestion on forms

Expected behavior:
Should show the saved address under about:autofill

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 10 x64
• Brave Version:
  0.12.3dev-RC1 (Clean install)
• Steps to reproduce:
  1. Add new address in about:autofill
  2. Click on save. Nothing happens
  3. Go to http://www.roboform.com/filling-test-all-fields, Double click on first name, autofill suggestion come. When clicked autofills all saved information
  4. Open about:autofill doesnt show the saved address
  5. Repeat steps 1-3 with new details, new details also shown in autofill suggestion
  6. Close all other tabs and open about:about, click on about:autofill
  7. Click on add address, Edit address modal doesn't show up when the page is opened from about:about. Only works when you do it from preferences page or manually open about:autofill (See screeshot gif)

Logged #4350 for the autofill modal issue

• Screenshot if needed:
  
• Any related issues:
  Autofill fails when adding address #4209

cc: @darkdh

[bbondy]

For me in step ii) when I click on save. Nothing happens. @darkdh has the same result as me. Can you guys think of any reason difference? If you move away your whole brave profile directory does it still reproduce?

[luixxiul]

I got a tricky combination:

if I put just s{2,4} in Name, the entry cannot be saved. otherwise the entry can be saved as above.

[darkdh]

This is mine on 0.12.3 RC1 windows 10

[srirambv]

For me anything I type gets saved but just doesn't show under saved address. But lists all of them as suggestions in form (Reproduced by moving %appdata%brave folder and created a new profile)

[luixxiul]

why does the autofill pulldown appear there by the way?

[srirambv]

Its showing in the roboform page but I just kept the mouse cursor on Autofill page to show saved address doesn't list. Ideally it shouldn't show in tab preview isn't it!!?

[bridiver]

there are actually two race conditions issues here

1. After saving the state, the autofill page immediately updates and can potentially try to read an address from the autofill db that hasn't persisted yet (OnPersonalDataChanged has not fired). Without listening for that callback there is no way to know when the ui should actually update
2. The race condition in Basic tab structure #1 triggers a appActions.removeAutofillAddress(addressDetail) because the profile data is empty. That call removes the data from the appState, but doesn't necessarily remove it from the autofill db because it hasn't been persisted there yet