-
Notifications
You must be signed in to change notification settings - Fork 973
Clicking Save Torrent File button does not save .torrent file #8146
Comments
@luixxiul let's retest with Preview 2 😄 https://github.com/brave/browser-laptop/releases/tag/v0.14.2dev-Preview2 |
On Preview 2 still the same error happens. |
Resolves brave#8146 Auditors: @bsclifton Test Plan: - Visit https://webtorrent.io/free-torrents/ - Click "Big Buck Bunny (torrent file)" - Click "Save Torrent File..." - File is saved
Resolves #8146 Auditors: @bsclifton Test Plan: - Visit https://webtorrent.io/free-torrents/ - Click "Big Buck Bunny (torrent file)" - Click "Save Torrent File..." - File is saved
The fix does not work on Windows 10 32 bit |
doesn't work on Ubuntu. It saves the page instead as described on STR. Reopening |
Tested on v0.15.0-RC3 |
Confirmed not working for OS X 0.15.0 RC3 cc @feross |
@alexwykoff I was fixing this error, so I can see that some merge conflicts were added, that's why it's not working. Let me do a followup |
Resolves brave#8146 Auditors: @bsclifton @bbondy Test Plan: - Visit https://webtorrent.io/free-torrents/ - Click "Big Buck Bunny (torrent file)" - Click "Save Torrent File..." - File is saved
Works fine on 0.15.0 RC4 |
This generally looks good to me, but it would be better to actually add the querystring with A couple examples:
Will send a PR to fix this. |
This feature broke again after PR #8325. My fault for not catching it during review. This PR fixes the code that is now on `master`. Addresses these comments: - #8446 (comment) - #8146 (comment) 52 It is better to add the '?download=true' querystring param with `url.parse` and `url.format` since blindly tacking on a '?download=true' can lead to invalid URLs. A couple examples: magnet:?a=b&c=d?download=true should use &download=true instead https://example.com/file.torrent#ix=1?download=true should not add a query param after a hash Also, this names the downloaded file correctly, which didn't seem to be working either after PR #8325.
PR sent: #8567 |
Test plan
#8567 (comment)
Original issue description
Describe the issue you encountered: Clicking Save Torrent File button does not save .torrent file. Instead it displays a prompt to save
webtorrent.html
. Also the CSP error which is same as #8145 is returned on devtool.Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10 32 bit
Brave Version (revision SHA): 0.14.2 Preview 1
Steps to reproduce:
Actual result:
webtorrent.html
is promptedExpected result: the torrent file should be prompted
Extra QA steps:
1.
2.
3.
Screenshot if needed:
Any related issues:
The text was updated successfully, but these errors were encountered: