This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix "Save Torrent File" feature #8567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature broke again after PR #8325. My fault for not catching it during review. This PR fixes the code that is now on `master`. Addresses these comments: - #8446 (comment) - #8146 (comment) 52 It is better to add the '?download=true' querystring param with `url.parse` and `url.format` since blindly tacking on a '?download=true' can lead to invalid URLs. A couple examples: magnet:?a=b&c=d?download=true should use &download=true instead https://example.com/file.torrent#ix=1?download=true should not add a query param after a hash Also, this names the downloaded file correctly, which didn't seem to be working either after PR #8325.
This was referenced Apr 29, 2017
diracdeltas
approved these changes
Apr 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8146
This feature broke again after PR #8325. My fault for not catching it
during review. This PR fixes the code that is now on
master.Addresses these comments:
It is better to add the '?download=true' querystring param with
url.parseandurl.formatsince blindly tacking on a'?download=true' can lead to invalid URLs.
A couple examples:
magnet:?a=b&c=d?download=trueis invalid and should use&download=trueinsteadhttps://example.com/file.torrent#ix=1?download=trueis invalid as there should not be a query param after a hashAlso, this names the downloaded file correctly, which didn't seem to be working either after PR #8325.
git rebase -ito squash commits (if needed).Didn't submit an issue since this isn't broken in a released version of Brave, just on
masteras of a few minutes ago. Lmk if I still should make an issue.Test Plan: