Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed URL bar shape consistency when payments are enabled/disabled #8170

Closed
srirambv opened this issue Apr 10, 2017 · 1 comment
Closed

Fixed URL bar shape consistency when payments are enabled/disabled #8170

srirambv opened this issue Apr 10, 2017 · 1 comment
Assignees
@NejcZdovc
Labels
design A design change, especially one which needs input from the design team. polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.15.0

Comments

@srirambv
Copy link
Collaborator

srirambv commented Apr 10, 2017 •
edited by luixxiul
Loading

Old title: URL bar shape is different with payments enabled/disabled when visiting a site #8170 (comment)

Test plan

#8207 (comment)

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    URL bar shape is different with payments enabled/disabled

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    0.14.1 Preivew 1

  • Steps to reproduce:

    1. Open a new tab and see the URL bar has rounded corners on all sides
    2. Visit a site in the new tab, the right corners change from rounded to sharp edge
    3. Enable payments and visit a new site in a new tab
    4. The inclusion of the verified publisher button causes the edge to be rounded but the URL bar inside still has sharp edges

  • Actual result:
    URL bar shape is different with payments enabled/disabled when visiting a site

  • Expected result:
    Corners should be same irrespective of payments enabled/disabled

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Mostly need to verify with an older build

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    urlshape

  • Any related issues:
    cc: @bradleyrichter @cezaraugusto
@srirambv srirambv added design A design change, especially one which needs input from the design team. polish Nice to have — usually related to front-end/visual tasks. labels Apr 10, 2017
@NejcZdovc NejcZdovc self-assigned this Apr 10, 2017
@NejcZdovc NejcZdovc added this to the 0.14.2 milestone Apr 10, 2017
@NejcZdovc
Copy link
Contributor

@srirambv This is something for me, because I was making changes to URL bar lately in #8059

@luixxiul luixxiul mentioned this issue Apr 10, 2017
Closed
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 10, 2017
@NejcZdovc
Fixes url bar shape when payment is disabled
f8f6d74 
Resolves brave#8170

Auditors: @srirambv @bsclifton

Test Plan:
- with payments disabled visit a site
- url border should be shaped
@NejcZdovc NejcZdovc mentioned this issue Apr 10, 2017
Merged
4 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 11, 2017
@NejcZdovc
Fixes url bar shape when payment is disabled
97da92d 
Resolves brave#8170

Auditors: @srirambv @bsclifton

Test Plan:
- with payments disabled visit a site
- url border should be shaped
cezaraugusto pushed a commit that referenced this issue Apr 11, 2017
@NejcZdovc @cezaraugusto
Fixes url bar shape when payment is disabled (#8207)
6293496 
Resolves #8170

Auditors: @srirambv @bsclifton

Test Plan:
- with payments disabled visit a site
- url border should be shaped
bsclifton pushed a commit that referenced this issue Apr 11, 2017
@NejcZdovc @bsclifton
Fixes url bar shape when payment is disabled (#8207)
92d3630 
Resolves #8170

Auditors: @srirambv @bsclifton

Test Plan:
- with payments disabled visit a site
- url border should be shaped
This was referenced Apr 13, 2017
Closed
Closed
Closed
Closed
This was referenced Apr 21, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
@alexwykoff alexwykoff changed the title URL bar shape is different with payments enabled/disabled when visiting a site Fixed URL bar shape consistency when payments are enabled/disabled Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
design A design change, especially one which needs input from the design team. polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
5 participants
@alexwykoff @luixxiul @cezaraugusto @NejcZdovc @srirambv