This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 975
opening pdf in new tab fails to load #8364
Labels
Milestone
Comments
diracdeltas
added a commit
that referenced
this issue
Apr 18, 2017
fix #8364 also adds LOAD_URL_REQUESTED message handler, which is needed for brave/pdf.js#2 test plan: 1. go to https://letsencrypt.org/repository/ 2. right click on any of the links to open in a new tab. it should work. 3. right click on any of the links to open in a new private tab. it should work.
4 tasks
bsclifton
pushed a commit
that referenced
this issue
Apr 18, 2017
fix #8364 also adds LOAD_URL_REQUESTED message handler, which is needed for brave/pdf.js#2 test plan: 1. go to https://letsencrypt.org/repository/ 2. right click on any of the links to open in a new tab. it should work. 3. right click on any of the links to open in a new private tab. it should work.
This was referenced Apr 18, 2017
doesn't work on Ubuntu. "Save as" dialog opens while opening on the same page but not for new tab/new private tab. Reopening |
This works great for me on Ubuntu 14.04 using 0.15.0 RC3 Can you retest this, @cezaraugusto? |
Also confirmed it works great on Ubuntu 16.04 |
I'm still not able to open PDF running the executable, but I did a new shot checking out RC3 tag branch and it worked. I can't say why as both are running muon 2.58.4. This is labeled as working on macOS and tested on two diff Ubuntu versions working good, so I'll close and keep an eye on RC4. @bsclifton thanks for tracking 🥇 |
alexwykoff
changed the title
opening pdf in new tab fails to load
Fixed opening pdf in new tab fails to load
Apr 25, 2017
luixxiul
changed the title
Fixed opening pdf in new tab fails to load
opening pdf in new tab fails to load
Aug 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan:
Original issue description
Did you search for similar issues before submitting this one?
yes
Platform (Win7, 8, 10? macOS? Linux distro?):
macOS
Brave Version (revision SHA):
0.14.1 / pdfjs 1.7.428
Steps to reproduce:
The text was updated successfully, but these errors were encountered: