Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

fix PDFJS loading PDFs in new tabs #8366

Merged
merged 1 commit into from
Apr 18, 2017
Merged

fix PDFJS loading PDFs in new tabs #8366

merged 1 commit into from
Apr 18, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Apr 18, 2017

fix #8364

also adds LOAD_URL_REQUESTED message handler, which is needed for brave/pdf.js#2

test plan:

  1. go to https://letsencrypt.org/repository/
  2. right click on any of the links to open in a new tab. it should work.
  3. right click on any of the links to open in a new private tab. it should work.
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

fix #8364

also adds LOAD_URL_REQUESTED message handler, which is needed for brave/pdf.js#2

test plan:
1. go to https://letsencrypt.org/repository/
2. right click on any of the links to open in a new tab. it should work.
3. right click on any of the links to open in a new private tab. it should work.
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look and work great 😄 ++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opening pdf in new tab fails to load
2 participants