Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Ctrl+W does not close a tab until another tab is hovered #8740

Closed
luixxiul opened this issue May 6, 2017 · 11 comments
Closed

Ctrl+W does not close a tab until another tab is hovered #8740

luixxiul opened this issue May 6, 2017 · 11 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented May 6, 2017

Describe the issue you encountered: Ctrl+W does not close a tab.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Debian

  • Brave Version (revision SHA): 1c04c53

  • Any related issues:

@luixxiul
Copy link
Contributor Author

luixxiul commented May 6, 2017

File -> Close on the main menu does not close tabs either

@luixxiul
Copy link
Contributor Author

luixxiul commented May 6, 2017

History -> Home also seem to be corrupted.

@NejcZdovc
Copy link
Contributor

Is this limited to debian only?

@darkdh
Copy link
Member

darkdh commented May 6, 2017

@NejcZdovc it happens on Mac too

@bsclifton
Copy link
Member

bsclifton commented May 7, 2017

@luixxiul do you have more info? There is a bad bug which may be causing this behavior:
#8640

Basically, if you mouse over any other tab... the Ctrl + W goes to that window instead. So it can appear that it's not working when it really does. This also would explain the other issues (since the action would be sent to the last tab which had a mouse hover)

@luixxiul luixxiul changed the title Ctrl+W does not close a tab Ctrl+W does not close a tab until another tab is hovered May 7, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented May 7, 2017

@bsclifton yeah after I move mouse over other tabs the shortcut/menu started working.

@bsclifton
Copy link
Member

@luixxiul hovering over another tab (because of the bug) should be causing that tab to closed or given input from the URL bar. Basically, once a tab is focused, it's as if you switched to it (even if you didn't). This is the bug that's captured

Do you think this issue here is a duplicate?

@luixxiul
Copy link
Contributor Author

luixxiul commented May 7, 2017

I could reproduce the bug you found, though I cannot tell if they have the same cause (surely they are related)

@NejcZdovc
Copy link
Contributor

@bsclifton @luixxiul I am right now trying to find out why #8640 is happening. I have some leads, but nothing concrete yet.

@NejcZdovc
Copy link
Contributor

@luixxiul can you try it again with the latest master? I think this should be fixed now.

@bsclifton
Copy link
Member

Fixed with #8782

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.